Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling service #302

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Sampling service #302

merged 8 commits into from
Nov 26, 2024

Conversation

sbekele81
Copy link
Collaborator

No description provided.

TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/Makefile.am Outdated Show resolved Hide resolved
TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/Makefile.am Outdated Show resolved Hide resolved
TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/Makefile.am Outdated Show resolved Hide resolved
TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/sampling_daemon.h Outdated Show resolved Hide resolved
TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/sampling_daemon.c Outdated Show resolved Hide resolved
TApplencourt
TApplencourt reviewed Nov 14, 2024
View reviewed changes
ze/sampling_daemon.c Outdated Show resolved Hide resolved
@TApplencourt
Copy link
Collaborator

The CI failed with

# /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:195:in `block in get_and_add_components': ze plugins was not found (RuntimeError)
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:192:in `each'
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:192:in `filter_map'
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:192:in `get_and_add_components'
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:314:in `no_gc'
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:329:in `create_and_run_graph'
# 	from /home/runner/work/THAPI/THAPI/build/ici/bin/babeltrace_thapi:461:in `<main>'
# I, [2024-11-15T15:02:33.254666 #6219]  INFO -- : IO dump: exit

@TApplencourt
Copy link
Collaborator

TApplencourt commented Nov 26, 2024 •
edited
Loading

LGTM, we should try to understand why the CI fail before merging.
Also can we try to add a sampling in the CI? Even if we just have OpenCL and will do nothing, at least we can check that when we pass --sampling to xprof it doesn't crash

TApplencourt
TApplencourt reviewed Nov 26, 2024
View reviewed changes
ze/Makefile.am Outdated Show resolved Hide resolved
@TApplencourt
Copy link
Collaborator

Ok perfect! Merging! gj

@TApplencourt TApplencourt merged commit 9dc3e23 into devel Nov 26, 2024
16 checks passed
@TApplencourt TApplencourt deleted the sampling_service branch November 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TApplencourt TApplencourt TApplencourt approved these changes

@Kerilk Kerilk Awaiting requested review from Kerilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbekele81 @TApplencourt @Kerilk @solo2abera