Checkpointing support for transformer type models #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hariharan-devarajan ready for you to review again. I added two other features since last time we talked:
|
hariharan-devarajan
requested changes
Feb 24, 2025
| if self.args.hidden_size <= 0: | ||
| return 0 | ||
| head_size = self.args.hidden_size//self.args.num_attention_heads | ||
| dim_kv = head_size * self.args.num_kv_heads |
There was a problem hiding this comment.
missed this. dim_kv
| mlp_4h_to_h = self.args.ffn_hidden_size*self.args.hidden_size | ||
| weight = self.args.hidden_size | ||
| lm_head = embedding | ||
| return embedding + (input_norm + qkv + dense + layer_norm + mlp_h_to_4h + mlp_4h_to_h)*self.args.num_layers + weight + lm_head |
There was a problem hiding this comment.
what is qkv and mlp_h_to_4h? if mlp_h_to_4h is too big then at least add a line comment on what it is, when it is defined.
|
|
||
| def get_layer_parameters(self, layer_index): | ||
| head_size = self.args.hidden_size//self.args.num_attention_heads | ||
| dim_kv = head_size * self.args.num_kv_heads |
There was a problem hiding this comment.
full form dim_kv
hariharan-devarajan
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we addressed the issue that people have to manually input layer parameters and optimization groups in the checkpointing. #248