Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multisource + upgrade k8s and argocd pkg + update to go 1.20 (fix #513) #548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tronix117
Copy link

Functional, however unit tests for multi-source needs to be updated.

fix: #513

@jannfis
Copy link
Contributor

jannfis commented Mar 31, 2023

Nice! Can we please decouple the upgrade of Argo CD, update of Go and the functional changes in three separate PRs?

@Tronix117
Copy link
Author

I can make two PRs :

  • one for update of GO and argoCD and K8S (because they are all related, k8s new dependencies versions are only compatible with go > 1.19)
  • this one for the multiple sources (but this one should be based on the other one, because we need new argocd, and thus new k8s version)

I still need to add some unit test for that, I'll do it when I can.

@jannfis
Copy link
Contributor

jannfis commented Apr 3, 2023

I can make two PRs

Sounds reasonable, thanks!

@amedinagar
Copy link

Thank you! we were developing something very similar, let me know if I can help.

@deferraz
Copy link
Contributor

deferraz commented May 8, 2023

Hey everyone! I've tested this PR in our environment and looks like it is working with multisource, to help this feature be available in a future release of argocd-image-updater I've already created the PR to bump golang release in a new pull request #564

@binboum
Copy link

binboum commented May 18, 2023

I tested the changes briefly, I noticed that it only updates the first element of the array when using multi source :

  sources: 
    - chart: elasticsearch # works
      repoURL: https://helm.elastic.co
      targetRevision: 8.5.1
    - repoURL: https://github.com/argoproj/argocd-example-apps.git # not works
      path: guestbook
      targetRevision: HEAD

@an-sy
Copy link

an-sy commented May 21, 2023

any plan when you will merge and release these feature?

deferraz pushed a commit to deferraz/argocd-image-updater that referenced this pull request Jun 21, 2023
deferraz pushed a commit to deferraz/argocd-image-updater that referenced this pull request Jun 21, 2023
@mecsys
Copy link

mecsys commented Jul 8, 2023

I tested too. Same behavior as mentioned by @binboum.

sources:
    - chart: ingress-nginx
      repoURL: https://kubernetes.github.io/ingress-nginx
      targetRevision: 4.4.2
      helm:
        releaseName: ingress-nginx
        valueFiles:
          - $values/infrastructure/production/infra-values/ingress-nginx/values.yaml        
    - ref: values
      repoURL: [email protected]:mecsys/mecsys-gitops.git
      targetRevision: main

@kvlxj
Copy link

kvlxj commented Sep 7, 2023

Hello,

any news on this feature ? It would be nice to implement this as we are generalizing the use of multi source app :)

@Iliabuleh
Copy link

Hey,

any plan when you will merge and release these feature?

Thanks !

@dermicus-miclip
Copy link

Seems like this PR is likely massively out of date. When will this get merged? I mean, it makes the project basically unusable when using multiple sources.

@devopsidiot
Copy link

Has any movement happened with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multiple Sources as per ArgoCD v2.6.0 New Field