Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter images by image-list annotation #651

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ziouf
Copy link

@ziouf ziouf commented Dec 8, 2023

Try to fix #650

@jannfis

@ziouf ziouf force-pushed the master branch 8 times, most recently from 45549e3 to 02a5542 Compare December 8, 2023 14:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d93c7a) 66.27% compared to head (8b13249) 66.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   66.27%   66.35%   +0.07%     
==========================================
  Files          22       22              
  Lines        2150     2155       +5     
==========================================
+ Hits         1425     1430       +5     
  Misses        591      591              
  Partials      134      134              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
return false
}

// GetImagesFromApplication returns the list of known images for the given application
func GetImagesFromApplication(app *v1alpha1.Application) image.ContainerImageList {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really like such approach, because you change total sense of this function. I think it would be better to add validation here. Either you need rename function and change comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Image should be filtered by image-list annotation
3 participants