feat: Support other namespaces than argocd in AIU #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sribiere-jellysmack
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 63.00% 63.09% +0.08%
==========================================
Files 31 31
Lines 3117 3124 +7
==========================================
+ Hits 1964 1971 +7
Misses 1009 1009
Partials 144 144 ☔ View full report in Codecov by Sentry. |
chengfang
reviewed
Jul 1, 2024
sribiere-jellysmack
force-pushed
the
master
branch
3 times, most recently
from
5f9ab59
to
3078882
Compare
jannfis
reviewed
Jul 2, 2024
sribiere-jellysmack
force-pushed
the
master
branch
from
24f6065
to
4df6f48
Compare
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
…er in TagInfoFromReferences (argoproj-labs#759) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
…/version.go (argoproj-labs#765) Signed-off-by: Mangaal <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: jannfis <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
…-labs#768) Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Cheng Fang <[email protected]> Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
sribiere-jellysmack
force-pushed
the
master
branch
from
4df6f48
to
b3da466
Compare
chengfang
reviewed
Jul 9, 2024
Signed-off-by: Sebastien RIBIERE <[email protected]>
sribiere-jellysmack
force-pushed
the
master
branch
from
b9d406c
to
83dbed4
Compare
Signed-off-by: Sebastien RIBIERE <[email protected]>
chengfang
approved these changes
Jul 9, 2024
|
Thanks @sribiere-jellysmack ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update an application in another namespace than argocd, AIU should include namespace in logs, and in writeback file.