Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linkerd example with header based routing #91

Merged
merged 5 commits into from
Dec 13, 2024
Merged

add linkerd example with header based routing #91

merged 5 commits into from
Dec 13, 2024
+307 −0

Conversation

AlonGluz
Copy link
Contributor

@AlonGluz AlonGluz commented Nov 11, 2024 •
edited
Loading

#84

@AlonGluz AlonGluz force-pushed the add-header-based-linkerd-example branch from 3c2640e to b942bb1 Compare November 11, 2024 13:43
@AlonGluz AlonGluz mentioned this pull request Nov 11, 2024
Closed
@AlonGluz
Copy link
Contributor Author

@kostis-codefresh Anything wrong with this PR?

kostis-codefresh
kostis-codefresh requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@kostis-codefresh kostis-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some extra instructions in the README specifically for header based routing.

@AlonGluz
Copy link
Contributor Author

AlonGluz commented Dec 8, 2024

@kostis-codefresh sure, I'll take care of it 👍🏻

@AlonGluz
add linkerd example with header baed routing
db0f4b3 
Signed-off-by: Alon Gluz <[email protected]>
Signed-off-by: Alon Gluz <[email protected]>
@AlonGluz AlonGluz force-pushed the add-header-based-linkerd-example branch from cfc6dad to da5094b Compare December 13, 2024 13:07
Alon Gluz and others added 4 commits December 13, 2024 15:09
@AlonGluz
fix typo
351a23b 
Signed-off-by: Alon Gluz <[email protected]>
Signed-off-by: Alon Gluz <[email protected]>
@AlonGluz
update readme to be more accurate with header based routing
df0a6a4 
Signed-off-by: Alon Gluz <[email protected]>
@AlonGluz
PR comments and use Linkerd version 2.14.10
bb2e94e 
Signed-off-by: Alon Gluz <[email protected]>
@AlonGluz
cleanup
4590d37 
Signed-off-by: Alon Gluz <[email protected]>
@AlonGluz AlonGluz force-pushed the add-header-based-linkerd-example branch from 13a2972 to 4590d37 Compare December 13, 2024 13:09
@AlonGluz
Copy link
Contributor Author

@kostis-codefresh I've applied the PR comments and tested it with L5d version 2.14.10, LMK if there are any other blockers

@kostis-codefresh kostis-codefresh merged commit 3997d28 into argoproj-labs:main Dec 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostis-codefresh kostis-codefresh Awaiting requested review from kostis-codefresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlonGluz @kostis-codefresh