feat: fetch & cache groups from UserInfo Endpoint #12062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
force-pushed
the
feature/server-side-groups-store
branch
from
beabd86 to
6c382e8
Compare
the-technat
changed the title
the-technat
force-pushed
the
feature/server-side-groups-store
branch
2 times, most recently
from
4afd686 to
52d5839
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12062 +/- ##
==========================================
- Coverage 49.55% 49.53% -0.02%
==========================================
Files 269 269
Lines 47039 47215 +176
==========================================
+ Hits 23310 23389 +79
- Misses 21443 21528 +85
- Partials 2286 2298 +12 ☔ View full report in Codecov by Sentry. |
the-technat
force-pushed
the
feature/server-side-groups-store
branch
22 times, most recently
from
30c49f7 to
081e72e
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
from
081e72e to
8d86e43
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
from
8d86e43 to
d9f94d9
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
2 times, most recently
from
5fa9e65 to
502d932
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
from
502d932 to
13f81ac
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
4 times, most recently
from
0d72f89 to
69be24c
Compare
the-technat
force-pushed
the
feature/server-side-groups-store
branch
3 times, most recently
from
96d4fa5 to
c8413ba
Compare
jannfis
reviewed
Nov 16, 2023
the-technat
force-pushed
the
feature/server-side-groups-store
branch
5 times, most recently
from
c5cbd3b to
3497aac
Compare
Signed-off-by: Nathanael Liechti <[email protected]>
the-technat
force-pushed
the
feature/server-side-groups-store
branch
from
3497aac to
72885b9
Compare
|
Again, please accept my apologies for the delayed review cycles. Thanks so much for contributing this! ❤️ |
alexymantha
pushed a commit
to alexymantha/argo-cd
that referenced
this pull request
Nov 22, 2023
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]>
filiprafaj
pushed a commit
to filiprafaj/argo-cd
that referenced
this pull request
Nov 23, 2023
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: Filip Rafaj <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…goproj#12062) Signed-off-by: Nathanael Liechti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try with a new approach to fix #8272 using a server-side approach. Every time the user does a request with it's OIDC token, argocd-server fetches the user's group information from the UserInfo endpoint (if enabled). The UserInfo response is cached (by default until the OIDC token expires) to avoid unneccesary requests/traffic.
For review some things to point out:
Closes #8272
Checklist: