Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow creating proj tokens in namespaces (#15333) #15334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iandelahorne
Copy link
Contributor

@iandelahorne iandelahorne commented Sep 4, 2023

Adds an optional group to the regex validating the policy object, allowing for creating API tokens for projects where a policy is targeting my-project/my-namespace/app-prefix*

Fixes #15333

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (92ce5a4) 49.92% compared to head (8b313ff) 49.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15334   +/-   ##
=======================================
  Coverage   49.92%   49.93%           
=======================================
  Files         263      263           
  Lines       45223    45223           
=======================================
+ Hits        22578    22581    +3     
+ Misses      20427    20425    -2     
+ Partials     2218     2217    -1     
Files Changed Coverage Δ
pkg/apis/application/v1alpha1/types.go 58.84% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Adds an optional group to the regex validating the policy object,
allowing for creating API tokens for projects where a policy is
targeting `my-project/my-namespace/app-prefix*`

fixes argoproj#15333

Signed-off-by: Ian Delahorne <[email protected]>
@iandelahorne iandelahorne force-pushed the project-tokens-in-namespaces branch from b58eead to 7346515 Compare September 10, 2023 18:33
Copy link
Member

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this needs:

  1. Tests
  2. Documentation
  3. Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create project token for policies using applications in namespaces
3 participants