Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show Traefik IngressRoute in network view #15369

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

2mas
Copy link

@2mas 2mas commented Sep 6, 2023

Displays the IngressRoute resource in the network view.

ExternalURLs dropdown is not populated here since it can be constructed by regexes both for path and hostnames, but the targeted Service's are connected and visualized.

image

Fixes #15368 <- enhancement proposal
Fixes the IngressRoute part of #11934


Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (aced025) 49.51% compared to head (96d7bba) 49.99%.

❗ Current head 96d7bba differs from pull request most recent head b3d5de3. Consider uploading reports for the commit b3d5de3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15369      +/-   ##
==========================================
+ Coverage   49.51%   49.99%   +0.48%     
==========================================
  Files         269      263       -6     
  Lines       46972    45276    -1696     
==========================================
- Hits        23257    22637     -620     
+ Misses      21433    20421    -1012     
+ Partials     2282     2218      -64     
Files Coverage Δ
controller/cache/info.go 67.81% <85.36%> (+1.04%) ⬆️

... and 71 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2mas 2mas force-pushed the master branch 2 times, most recently from 555a7c6 to eef5bea Compare September 8, 2023 08:57
@2mas 2mas marked this pull request as ready for review September 8, 2023 09:01
@2mas 2mas requested a review from a team as a code owner November 3, 2023 13:09
@ChristianCiach
Copy link
Contributor

How can we progress here? Is there anything missing?

@2mas
Copy link
Author

2mas commented Jun 14, 2024

I was hoping for some feedback to come in, but I'm not chasing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Traefik IngressRoute to network view
2 participants