-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve the double scroll bars in the application view. fixes #14588 #15384
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15384 +/- ##
=======================================
Coverage 49.54% 49.55%
=======================================
Files 269 269
Lines 46641 46641
=======================================
+ Hits 23110 23113 +3
+ Misses 21258 21256 -2
+ Partials 2273 2272 -1 ☔ View full report in Codecov by Sentry. |
2a6d88b
to
cc7fafe
Compare
da0c434
to
f6d50ea
Compare
Signed-off-by: Joe Lombrozo <[email protected]>
f6d50ea
to
a5cd09f
Compare
@keithchong @alexmt @rbreeze could one of you please review and possibly approve this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rbreeze any chance of getting this merged/released, or are we waiting for a merge window or something? not sure what the release process is here. |
/cherry-pick release-2.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djeebus can you rebase the PR and resolve conflicts??
I'm running 2.9.3 and I don't see this issue any more. Must have been fixed in someone else's PR recently. I'll close mine. |
Cherry-pick failed with |
If the applications page is sufficiently large, the page has double scrollbars (see below). I believe the root cause of this was #12068, and was mentioned by @n9 in that same PR. This PR cleans that up, and tweaks a few margin/paddings that were probably tweaked to try and work around this issue.
Before:
After:
Fixes #14588
Checklist: