Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the double scroll bars in the application view. fixes #14588 #15384

Closed
wants to merge 4 commits into from

Conversation

djeebus
Copy link
Contributor

@djeebus djeebus commented Sep 6, 2023

If the applications page is sufficiently large, the page has double scrollbars (see below). I believe the root cause of this was #12068, and was mentioned by @n9 in that same PR. This PR cleans that up, and tweaks a few margin/paddings that were probably tweaked to try and work around this issue.

Before:
image

After:
image

Fixes #14588

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91875c0) 49.54% compared to head (19503ea) 49.55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15384   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files         269      269           
  Lines       46641    46641           
=======================================
+ Hits        23110    23113    +3     
+ Misses      21258    21256    -2     
+ Partials     2273     2272    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djeebus djeebus marked this pull request as ready for review September 6, 2023 21:33
@djeebus djeebus force-pushed the fix-double-bars branch 2 times, most recently from da0c434 to f6d50ea Compare September 11, 2023 14:31
@jannfis
Copy link
Member

jannfis commented Sep 13, 2023

@keithchong @alexmt @rbreeze could one of you please review and possibly approve this PR?

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djeebus
Copy link
Contributor Author

djeebus commented Sep 25, 2023

@rbreeze any chance of getting this merged/released, or are we waiting for a merge window or something? not sure what the release process is here.

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@djeebus djeebus requested review from a team as code owners October 5, 2023 14:03
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeebus can you rebase the PR and resolve conflicts??

@djeebus
Copy link
Contributor Author

djeebus commented Feb 11, 2024

I'm running 2.9.3 and I don't see this issue any more. Must have been fixed in someone else's PR recently. I'll close mine.

@djeebus djeebus closed this Feb 11, 2024
Copy link

Cherry-pick failed with Merge error b1b044e74d9f4230d1ca86384c94c07af1936fd4 into temp-cherry-pick-8bb0d0-release-2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD Horizontal Scrollbar only available once bottom of screen reached.
5 participants