fix: handle annotations for resources with ':' in the name (#15101) (cherry-pick #15380) #15414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer <[email protected]> * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer <[email protected]> * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer <[email protected]> * Retrigger CI pipeline Signed-off-by: Oreon Lothamer <[email protected]> --------- Signed-off-by: Oreon Lothamer <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.8 #15414 +/- ##
============================================
Coverage 49.94% 49.94%
============================================
Files 263 263
Lines 45067 45067
============================================
Hits 22508 22508
Misses 20350 20350
Partials 2209 2209
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
jannfis
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: handle annotations for resources with ':' in the name (#15101) (#15380)
Signed-off-by: Oreon Lothamer [email protected]
Signed-off-by: Oreon Lothamer [email protected]
Signed-off-by: Oreon Lothamer [email protected]
Signed-off-by: Oreon Lothamer [email protected]
Signed-off-by: Oreon Lothamer [email protected]