-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New kube applier for server side diff dry run with refactoring (#21488) #21819
fix: New kube applier for server side diff dry run with refactoring (#21488) #21819
Conversation
…rgoproj#21488) (argoproj#21749) Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #21819 +/- ##
================================================
- Coverage 55.19% 55.17% -0.03%
================================================
Files 338 338
Lines 57181 57195 +14
================================================
- Hits 31563 31555 -8
- Misses 22924 22937 +13
- Partials 2694 2703 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all changes made in the manifests
folder. This is a known issue with cherry-picks.
Signed-off-by: Andrii Korotkov <[email protected]>
Done, hope CI for that is non-blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-picks #21749 to 2.14 with necessary modifications.
Checklist: