fix: stop rollout from entering degraded state during blueGreen pause. …

…Fixes #3843 (#3845) add check for overall pause condition to indefinite step Signed-off-by: Miles <[email protected]> Co-authored-by: Miles <[email protected]>
argoproj · Sep 27, 2024 · 4e44913 · 4e44913
1 parent 9b60eca
commit 4e44913
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rollout/sync.go b/rollout/sync.go
@@ -562,7 +562,10 @@ func isIndefiniteStep(r *v1alpha1.Rollout) bool {
 	if currentStep != nil && (currentStep.Experiment != nil || currentStep.Analysis != nil || currentStep.Pause != nil) {
 		return true
 	}
-	return false
+	// also check the pause condition to cover blueGreen
+	pauseCond := conditions.GetRolloutCondition(r.Status, v1alpha1.RolloutPaused)
+	pausedCondTrue := pauseCond != nil && pauseCond.Status == corev1.ConditionTrue
+	return pausedCondTrue
 }
 
 // isWaitingForReplicaSetScaleDown returns whether or not the rollout still has other replica sets with a scale down deadline annotation