Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metricprovider): not require address in kubernetes secret for Datadog. Fixes #4103 #4145

Merged

Conversation

TAKAyukiatkwsk
Copy link
Contributor

@TAKAyukiatkwsk TAKAyukiatkwsk commented Feb 20, 2025

Fix #4103

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@TAKAyukiatkwsk TAKAyukiatkwsk marked this pull request as draft February 20, 2025 02:44
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Published E2E Test Results

  4 files    4 suites   3h 8m 56s ⏱️
113 tests 106 ✅  7 💤 0 ❌
452 runs  424 ✅ 28 💤 0 ❌

Results for commit c2c7982.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Published Unit Test Results

2 301 tests   2 301 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit c2c7982.

♻️ This comment has been updated with latest results.

@TAKAyukiatkwsk TAKAyukiatkwsk force-pushed the fix-find-credentials-datadog branch from d328350 to c2c7982 Compare February 20, 2025 03:29
@zachaller zachaller merged commit 494bfd9 into argoproj:master Feb 21, 2025
25 checks passed
zachaller pushed a commit that referenced this pull request Feb 21, 2025
…adog. Fixes #4103 (#4145)

fix(metricprovider): not require address in kubernetes secret for Datadog

Signed-off-by: Takayuki Takagi <[email protected]>
zachaller pushed a commit that referenced this pull request Feb 21, 2025
…adog. Fixes #4103 (#4145)

fix(metricprovider): not require address in kubernetes secret for Datadog

Signed-off-by: Takayuki Takagi <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.8 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to find the credentials for datadog metrics provider in v1.8.0
2 participants