fix(ui): remove accidentally rendered semi-colon (#12060)

Signed-off-by: Anton Gilgur <[email protected]>
argoproj · Oct 21, 2023 · 7567775 · 7567775
1 parent 03a6168
commit 7567775
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/ui/src/app/cron-workflows/components/cron-workflow-details/cron-workflow-details.tsx b/ui/src/app/cron-workflows/components/cron-workflow-details/cron-workflow-details.tsx
@@ -6,6 +6,7 @@ import * as models from '../../../../models';
 import {CronWorkflow, Link, Workflow} from '../../../../models';
 import {uiUrl} from '../../../shared/base';
 import {ErrorNotice} from '../../../shared/components/error-notice';
+import {openLinkWithKey} from '../../../shared/components/links';
 import {Loading} from '../../../shared/components/loading';
 import {useCollectEvent} from '../../../shared/components/use-collect-event';
 import {ZeroState} from '../../../shared/components/zero-state';
@@ -20,7 +21,7 @@ import {CronWorkflowEditor} from '../cron-workflow-editor';
 require('../../../workflows/components/workflow-details/workflow-details.scss');
 require('./cron-workflow-details.scss');
 
-export const CronWorkflowDetails = ({match, location, history}: RouteComponentProps<any>) => {
+export function CronWorkflowDetails({match, location, history}: RouteComponentProps<any>) {
     // boiler-plate
     const {navigation, notifications, popup} = useContext(Context);
     const queryParams = new URLSearchParams(location.search);
@@ -107,14 +108,6 @@ export const CronWorkflowDetails = ({match, location, history}: RouteComponentPr
                   disabled: !cronWorkflow || !cronWorkflow.spec.suspend || edited
               };
 
-    const openLink = (link: Link) => {
-        if ((window.event as MouseEvent).ctrlKey || (window.event as MouseEvent).metaKey) {
-            window.open(link.url, '_blank');
-        } else {
-            document.location.href = link.url;
-        }
-    };
-
     const getItems = () => {
         const items = [
             {
@@ -193,7 +186,7 @@ export const CronWorkflowDetails = ({match, location, history}: RouteComponentPr
             items.push({
                 title: templateLink.name,
                 iconClassName: icon,
-                action: () => openLink(templateLink)
+                action: () => openLinkWithKey(templateLink.url)
             });
         }
 
@@ -262,4 +255,4 @@ export const CronWorkflowDetails = ({match, location, history}: RouteComponentPr
             </>
         </Page>
     );
-};
+}
diff --git a/ui/src/app/reports/components/reports.tsx b/ui/src/app/reports/components/reports.tsx
@@ -87,7 +87,7 @@ export function Reports({match, location, history}: RouteComponentProps<any>) {
                     <ReportFilters namespace={namespace} labels={labels} onChange={onChange} />
                 </div>
                 <div className='columns small-12 xlarge-10'>
-                    <ErrorNotice error={error} />;
+                    <ErrorNotice error={error} />
                     {!charts ? (
                         <ZeroState title='Workflow Report'>
                             <p>