fix: Workflow controller crash on nil pointer (#11770)

argoproj · Sep 7, 2023 · 75bd0b8 · 75bd0b8
1 parent 1f2e822
commit 75bd0b8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/workflow/controller/healthz.go b/workflow/controller/healthz.go
@@ -33,6 +33,11 @@ func (wfc *WorkflowController) Healthz(w http.ResponseWriter, r *http.Request) {
 		if err != nil {
 			return err
 		}
+		// the wfc.wfInformer is nil if it is not the leader
+		if wfc.wfInformer == nil {
+			log.Info("healthz: current pod is not the leader")
+			return nil
+		}
 		lister := v1alpha1.NewWorkflowLister(wfc.wfInformer.GetIndexer())
 		list, err := lister.Workflows(wfc.managedNamespace).List(seletor)
 		if err != nil {