Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deps): replace unmaintained pkg/errors with fmt.Errorf #7440

Merged
merged 12 commits into from
Mar 18, 2022
Merged

refactor(deps): replace unmaintained pkg/errors with fmt.Errorf #7440

merged 12 commits into from
Mar 18, 2022

Conversation

stephpalis
Copy link
Contributor

@stephpalis stephpalis commented Dec 17, 2021 •
edited by alexec
Loading

Signed-off-by: Stephanie Palis [email protected]
Fixes #7402

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

This PR removes the functionality of StackTracer as a result of removing pkg/errors

@stephpalis stephpalis marked this pull request as ready for review January 25, 2022 18:07
alexec
alexec requested changes Jan 27, 2022
View reviewed changes
errors/errors_test.go Outdated Show resolved Hide resolved
util/errors/errors.go Outdated Show resolved Hide resolved
util/kubeconfig/kubeconfig.go Outdated Show resolved Hide resolved
workflow/executor/resource.go Outdated Show resolved Hide resolved
errors/errors.go Outdated Show resolved Hide resolved
alexec
alexec reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this changes behaviour, lets hold off merging until v3.4

@blkperl blkperl mentioned this pull request Feb 3, 2022
Closed
@alexec alexec added the v3.4 label Feb 14, 2022
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the problem/stale This has not had a response in some time label Feb 22, 2022
@stale stale bot removed the problem/stale This has not had a response in some time label Feb 22, 2022
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@alexec alexec removed the v3.4 label Mar 9, 2022
@stale stale bot removed the problem/stale This has not had a response in some time label Mar 9, 2022
@blkperl
Copy link
Contributor

blkperl commented Mar 17, 2022

@alexec 3.3 is tagged, are we good to merge this?

@alexec
Copy link
Contributor

alexec commented Mar 17, 2022

needs conflict resolution

@stephpalis
Copy link
Contributor Author

@alexec pushed up a commit, if you could retrigger the test suite

@alexec alexec merged commit 051c7b8 into argoproj:master Mar 18, 2022
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request Mar 23, 2022
@stephpalis @dpadhiar
fix: pkg/errors is no longer maintained (argoproj#7440)
62be1be 
* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
Closed
85 tasks
@sarabala1979 sarabala1979 mentioned this pull request May 25, 2022
Closed
14 tasks
sarabala1979 pushed a commit that referenced this pull request May 25, 2022
@stephpalis @sarabala1979
fix: pkg/errors is no longer maintained (#7440)
7091d80 
* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>

* fix: pkg/errors is no longer maintained

Signed-off-by: Stephanie Palis <[email protected]>
@blkperl blkperl mentioned this pull request Sep 27, 2024
Merged
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies type/tech-debt labels Sep 28, 2024
@agilgur5 agilgur5 changed the title fix: pkg/errors is no longer maintained refactor: replace unmaintained pkg/errors with fmt.Errorf Sep 28, 2024
@agilgur5 agilgur5 changed the title refactor: replace unmaintained pkg/errors with fmt.Errorf refactor(deps): replace unmaintained pkg/errors with fmt.Errorf Sep 28, 2024
@agilgur5 agilgur5 mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blkperl blkperl blkperl left review comments

@alexec alexec alexec approved these changes

Assignees

@alexec alexec

Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/errors is no longer maintained
4 participants
@stephpalis @blkperl @alexec @agilgur5