bump k8s v1.33 and remove all replaces #717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should start from migration of golangci-lint |
|
On it: #719 |
Signed-off-by: sivchari <[email protected]>
|
Thx! rebsaed. |
…t is not necessary anymore Signed-off-by: sivchari <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 54.26% 47.57% -6.70%
==========================================
Files 64 63 -1
Lines 6164 6443 +279
==========================================
- Hits 3345 3065 -280
- Misses 2549 3125 +576
+ Partials 270 253 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14 tasks
| @@ -905,25 +907,26 @@ func normalizeEndpoint(un *unstructured.Unstructured, o options) { | |||
| if gvk.Group != "" || gvk.Kind != "Endpoints" { | |||
| return | |||
| } | |||
| var ep corev1.Endpoints | |||
| var ep discoveryv1.EndpointSlice | |||
There was a problem hiding this comment.
I don't understand this change... the code seems to be specific to normalization of endpoints, not endpoint slices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Kubernetes dependency to 1.33, then delete all replace directives since it's no necessary. If we use lower kubernetes dependency in other repo and depends on gitops-engine, Go prefers dependency of gitops-engine. On the other hand, if we use higher it, Go prefers dependency of other repo. In addition, the number of dependencies from gitops-engine to Kubernetes is a few, so it's easy to maintain rather than to deal with replace directive.
If necessary, I'd like to maintain about it in the future too.