perf: avoid multiple script injection

argos-ci · Dec 13, 2023 · 12e0748 · 12e0748
1 parent 23c4a3d
commit 12e0748
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/packages/cypress/src/support.ts b/packages/cypress/src/support.ts
@@ -30,15 +30,16 @@ declare global {
 }
 
 function injectArgos() {
-  const fileName =
-    typeof require.resolve === "function"
-      ? require.resolve("@argos-ci/browser/global.js")
-      : "node_modules/@argos-ci/browser/dist/global.js";
-  cy.readFile<string>(fileName).then((source) =>
-    cy.window({ log: false }).then((window) => {
+  cy.window({ log: false }).then((window) => {
+    if (typeof (window as any).__ARGOS__ !== "undefined") return;
+    const fileName =
+      typeof require.resolve === "function"
+        ? require.resolve("@argos-ci/browser/global.js")
+        : "node_modules/@argos-ci/browser/dist/global.js";
+    return cy.readFile<string>(fileName).then((source) => {
       window.eval(source);
-    }),
-  );
+    });
+  });
 }
 
 function readArgosCypressVersion() {

diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts
@@ -46,6 +46,10 @@ export type ArgosScreenshotOptions = {
  * Inject Argos script into the page.
  */
 async function injectArgos(page: Page) {
+  const injected = await page.evaluate(
+    () => typeof (window as any).__ARGOS__ !== "undefined",
+  );
+  if (injected) return;
   const fileName = require.resolve("@argos-ci/browser/global.js");
   const content = await readFile(fileName, "utf-8");
   await page.addScriptTag({ content });

diff --git a/packages/puppeteer/src/index.ts b/packages/puppeteer/src/index.ts
@@ -17,6 +17,10 @@ const require = createRequire(import.meta.url);
  * Inject Argos script into the page.
  */
 async function injectArgos(page: Page) {
+  const injected = await page.evaluate(
+    () => typeof (window as any).__ARGOS__ !== "undefined",
+  );
+  if (injected) return;
   const fileName = require.resolve("@argos-ci/browser/global.js");
   const content = await readFile(fileName, "utf-8");
   await page.addScriptTag({ content });