chore: add not null constraint on files.type

apps/backend/db/migrations/20231115210334_file-type-not-null.js

@@ -0,0 +1,31 @@
+/**
+ * @param {import('knex').Knex} knex
+ */
+export const up = async (knex) => {
+  await knex.raw(`
+    ALTER TABLE files ADD CONSTRAINT files_type_not_null_constraint CHECK (type IS NOT NULL) NOT VALID;
+  `);
+
+  await knex.raw(`
+    ALTER TABLE files VALIDATE CONSTRAINT files_type_not_null_constraint;
+  `);
+
+  await knex.raw(`
+    ALTER TABLE files ALTER column type SET NOT NULL;
+  `);
+
+  await knex.raw(`
+    ALTER TABLE files DROP CONSTRAINT files_type_not_null_constraint;
+  `);
+};
+
+/**
+ * @param {import('knex').Knex} knex
+ */
+export const down = async (knex) => {
+  await knex.raw(`
+    ALTER TABLE files ALTER column type DROP NOT NULL;
+  `);
+};
+
+export const config = { transaction: false };

apps/backend/db/structure.sql

@@ -292,7 +292,7 @@ CREATE TABLE public.files (
     key character varying(255) NOT NULL,
     width integer,
     height integer,
-    type text,
+    type text NOT NULL,
     CONSTRAINT files_type_check CHECK ((type = ANY (ARRAY['screenshot'::text, 'screenshotDiff'::text, 'playwrightTrace'::text])))
 );
 
@@ -2757,4 +2757,5 @@ INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('2023102
 INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231024085955_fix-github-account-type-constraint.js', 1, NOW());
 INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231106114751_pw-traces.js', 1, NOW());
 INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231115151718_file-type.js', 1, NOW());
-INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231115160027_playwrightTraceIndex.js', 1, NOW());
+INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231115160027_playwrightTraceIndex.js', 1, NOW());
+INSERT INTO public.knex_migrations(name, batch, migration_time) VALUES ('20231115210334_file-type-not-null.js', 1, NOW());

apps/backend/src/database/models/File.ts

@@ -5,13 +5,13 @@ export class File extends Model {
   static override tableName = "files";
 
   static override jsonSchema = mergeSchemas(timestampsSchema, {
-    required: ["key"],
+    required: ["key", "type"],
     properties: {
       key: { type: ["string"] },
       width: { type: ["number", "null"], minimum: 0 },
       height: { type: ["number", "null"], minimum: 0 },
       type: {
-        type: ["string", "null"],
+        type: "string",
         enum: ["screenshot", "screenshotDiff", "playwrightTrace"],
       },
     },
@@ -20,5 +20,5 @@ export class File extends Model {
   key!: string;
   width!: number | null;
   height!: number | null;
-  type!: "screenshot" | "screenshotDiff" | "playwrightTrace" | null;
+  type!: "screenshot" | "screenshotDiff" | "playwrightTrace";
 }