Merge pull request #1416 from argos-ci/fix-empty-query

fix: fix empty query
argos-ci · Nov 12, 2024 · b0721b1 · b0721b1
2 parents 81f9da4 + 56d730b
commit b0721b1
Showing 1 changed file with 21 additions and 19 deletions.
diff --git a/apps/backend/src/build/partial.ts b/apps/backend/src/build/partial.ts
@@ -176,25 +176,27 @@ export async function finalizePartialBuilds(input: {
         )
         .returning("id");
 
-      await Screenshot.query().insert(
-        missingShards.flatMap((shard, index) => {
-          const insertedShard = insertedShards[index];
-          invariant(insertedShard, "Inserted shard should be found");
-          invariant(shard.screenshots, "Screenshots should be fetched");
-          return shard.screenshots.map((screenshot) => {
-            return {
-              name: screenshot.name,
-              s3Id: screenshot.s3Id,
-              screenshotBucketId: build.compareScreenshotBucketId,
-              fileId: screenshot.fileId,
-              testId: screenshot.testId,
-              metadata: screenshot.metadata,
-              playwrightTraceFileId: screenshot.playwrightTraceFileId,
-              buildShardId: insertedShard.id,
-            };
-          });
-        }),
-      );
+      const missingScreenshots = missingShards.flatMap((shard, index) => {
+        const insertedShard = insertedShards[index];
+        invariant(insertedShard, "Inserted shard should be found");
+        invariant(shard.screenshots, "Screenshots should be fetched");
+        return shard.screenshots.map((screenshot) => {
+          return {
+            name: screenshot.name,
+            s3Id: screenshot.s3Id,
+            screenshotBucketId: build.compareScreenshotBucketId,
+            fileId: screenshot.fileId,
+            testId: screenshot.testId,
+            metadata: screenshot.metadata,
+            playwrightTraceFileId: screenshot.playwrightTraceFileId,
+            buildShardId: insertedShard.id,
+          };
+        });
+      });
+
+      if (missingScreenshots.length > 0) {
+        await Screenshot.query().insert(missingScreenshots);
+      }
 
       await finalizeBuild({ build });
       await buildJob.push(build.id);