Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add purchase status #1110

Merged
merged 2 commits into from
Nov 23, 2023
Merged

feat: add purchase status #1110

merged 2 commits into from
Nov 23, 2023

Conversation

jsfez
Copy link
Contributor

@jsfez jsfez commented Nov 23, 2023

No description provided.

@jsfez jsfez requested review from a team and gregberge and removed request for a team November 23, 2023 11:23
@argos-ci Argos CI
Copy link

argos-ci bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 23, 2023, 2:08 PM

@jsfez jsfez force-pushed the add-puchase-status-field branch 2 times, most recently from 32c59e6 to 44715f9 Compare November 23, 2023 12:19
@jsfez jsfez force-pushed the add-puchase-status-field branch from 44715f9 to 11d8648 Compare November 23, 2023 12:38
gregberge
gregberge previously requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trialing was dynamic and now it is no longer the case, I don't see anything in code that updates the status from trialing to canceled or to active.

apps/backend/src/synchronize/github/updatePurchase.ts Outdated Show resolved Hide resolved
apps/backend/db/migrations/20231122143018_add-purchase-status.js Outdated Show resolved Hide resolved
apps/backend/db/migrations/20231122143018_add-purchase-status.js Outdated Show resolved Hide resolved
apps/backend/db/migrations/20231122143018_add-purchase-status.js Outdated Show resolved Hide resolved
apps/backend/db/structure.sql Outdated Show resolved Hide resolved
apps/backend/db/structure.sql Outdated Show resolved Hide resolved
apps/backend/db/structure.sql Outdated Show resolved Hide resolved
@jsfez jsfez force-pushed the add-puchase-status-field branch 3 times, most recently from e194985 to 379390c Compare November 23, 2023 14:02
@jsfez jsfez force-pushed the add-puchase-status-field branch from 379390c to 6bfdadf Compare November 23, 2023 14:05
@jsfez jsfez enabled auto-merge November 23, 2023 14:10
@jsfez jsfez disabled auto-merge November 23, 2023 14:12
@jsfez jsfez merged commit ee62bc2 into main Nov 23, 2023
6 checks passed
@jsfez jsfez deleted the add-puchase-status-field branch November 23, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregberge gregberge gregberge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsfez @gregberge