Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paginate github repo list #1147

Merged
merged 1 commit into from
Jan 14, 2024
Merged

feat: paginate github repo list #1147

merged 1 commit into from
Jan 14, 2024

Conversation

jsfez
Copy link
Contributor

@jsfez jsfez commented Jan 14, 2024

CleanShot 2024-01-14 at 17 56 58@2x

CleanShot 2024-01-14 at 17 57 13@2x

CleanShot 2024-01-14 at 17 57 18@2x

CleanShot 2024-01-14 at 17 57 25@2x

Copy link

argos-ci bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jan 14, 2024, 5:58 PM

@jsfez jsfez force-pushed the paginate-github-repos branch from 92a57c5 to b30617f Compare January 14, 2024 17:55
@jsfez jsfez force-pushed the paginate-github-repos branch from b30617f to 8d3151e Compare January 14, 2024 17:56
@jsfez jsfez requested a review from gregberge January 14, 2024 17:56
Copy link
Member

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think previous / next would have been enough but fine. Also could you please put 100 repos per page? I think it's better to avoid pagination if possible.

@jsfez jsfez merged commit ca0ca9e into main Jan 14, 2024
7 checks passed
@jsfez jsfez deleted the paginate-github-repos branch January 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants