Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firefox): fix diff display on Firefox #1167

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

gregberge
Copy link
Member

@gregberge gregberge commented Jan 26, 2024

Firefox has a bug measuring the content of a "relative" div. It does not give the size of its children. To fix this problem we size correctly the parent div.

Before
CleanShot 2024-01-26 at 09 20 45@2x

After
CleanShot 2024-01-26 at 09 21 03@2x

@gregberge gregberge requested review from a team and jsfez and removed request for a team January 26, 2024 08:21
Copy link

argos-ci bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Jan 26, 2024, 12:08 PM

@gregberge gregberge force-pushed the fix-firefox-build-2 branch from 89a1129 to d652ec3 Compare January 26, 2024 08:31
@gregberge gregberge force-pushed the fix-firefox-build-2 branch from 0b16d57 to 8a09443 Compare January 26, 2024 12:06
@gregberge gregberge merged commit 5cf993b into main Jan 26, 2024
5 checks passed
@gregberge gregberge deleted the fix-firefox-build-2 branch January 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants