-
Notifications
You must be signed in to change notification settings - Fork 6.2k
ci: build linux arm static binaries #16271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e4ce5ad to
761c414
Compare
761c414 to
2e9c63c
Compare
09a9f51 to
1c67eaf
Compare
4411675 to
1fab8cd
Compare
1fab8cd to
b5beaf1
Compare
|
Should we also add a section on the documentation about the arm binaries? https://github.com/argotorg/solidity/blob/8cb16a10711de9d52fcee020d609d504c1ef4abe/docs/installing-solidity.rst#static-binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some small comments, it looks good to me ;)
| - b_bytecode_ems | ||
|
|
||
| # Final artifacts | ||
| - c_release_binaries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested c_release_binaries job and final binary produced? You could remove the on_version_tags filter and push to another branch to test it if not already.
It's not any different from regular linux releases, don't think it needs to be mentioned explicitly. Certainly not in a whole section. The most i'd do would be mentioning that we also support arm64 from 0.8.31 |
Fair enough. Yeah, it would be nice to have that information somewhere indeed. But maybe having it the changelog is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already approving. Since the release test should probably pass (https://app.circleci.com/pipelines/github/argotorg/solidity/40725/workflows/97daf0b8-36ae-4f4c-88c7-ad5f55a3d037). But if you think it is also good to add to the docs that we support arm64 from version 0.8.3, feel free to do so.
b5beaf1 to
be37565
Compare
No description provided.