SSACFG backend: add stack abstraction #16273
Merged
+405
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
reviewed
Oct 31, 2025
clonker
force-pushed
the
ssacfg_stack
branch
2 times, most recently
from
d78bc8b to
fb5d814
Compare
blishko
previously approved these changes
Nov 3, 2025
Collaborator
blishko
left a comment
blishko
left a comment
There was a problem hiding this comment.
I am approving this, but it would be good if someone else takes a look as well.
clonker
force-pushed
the
ssacfg_stack
branch
2 times, most recently
from
1499e00 to
edcef85
Compare
blishko
reviewed
Nov 3, 2025
libyul/backends/evm/ssa/Stack.h
Outdated
| yulAssert(dupReachable(_offset), "Stack too deep"); | ||
| m_data->push_back((*m_data)[_offset.value]); | ||
| if constexpr (!std::is_same_v<Callbacks, NoOpStackManipulationCallbacks>) | ||
| m_callbacks.dup(_offset.value + 1); |
Collaborator
There was a problem hiding this comment.
I am having some doubts here.
Why are we calling it with offset + 1?
Can you clarify if the callbacks expect Offset or Depth in dup and swap?
Maybe the strong type can be used already in the concept, to avoid any confusion?
Maybe your originally version was better? 😅
Member
Author
There was a problem hiding this comment.
The callback expects it as EVM instruction. So DUP1 is a dup(Depth{0}) is a dup(Offset{size() - 1}). Which means I was too tired apparently to implement the change properly. ^^ Let me fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.