Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-media): add --forcedColors to the custom media queries list #445

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat(custom-media): add --forcedColors to the custom media queries list #445

merged 2 commits into from
Dec 7, 2023

Conversation

cbontems
Copy link
Contributor

@cbontems cbontems commented Dec 7, 2023

Oh, I missed the timing to slide this one in the previous PR, so here it is in a new one.

Adds @custom-media --forcedColors (forced-colors: active); to the custom MQ list.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

argyleink
argyleink requested changes Dec 7, 2023
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs added to the docsite as well, then this is g2g!

@cbontems
Copy link
Contributor Author

cbontems commented Dec 7, 2023

I forgot the docs site... It is done now.
I added it to the Preference Vars group.

@cbontems cbontems requested a review from argyleink December 7, 2023 23:43
argyleink
argyleink approved these changes Dec 7, 2023
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad! ty, this is great 👍🏻

@argyleink argyleink merged commit de7cd15 into argyleink:main Dec 7, 2023
2 checks passed
@cbontems cbontems deleted the fix/forcedColorsMQ branch December 8, 2023 00:10
@cbontems
Copy link
Contributor Author

cbontems commented Dec 8, 2023

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbontems @argyleink