atlasaction: add code suggestion comments to migrate lint action #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronenlu
changed the title
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
|
Migrations automatically reviewed with Atlas |
|
Migrations automatically reviewed with Atlas |
ronenlu
force-pushed
the
code_suggestions
branch
from
b42ef76 to
2555eaa
Compare
ronenlu
force-pushed
the
code_suggestions
branch
6 times, most recently
from
5e0c4f1 to
8ff887a
Compare
ronenlu
force-pushed
the
code_suggestions
branch
from
8ff887a to
495d388
Compare
ronenlu
commented
Feb 15, 2024
| @@ -355,20 +355,20 @@ func TestMigrateLint(t *testing.T) { | |||
| require.NoError(t, err) | |||
| require.Equal(t, 0, len(out)) | |||
| }) | |||
| t.Run("lint with error", func(t *testing.T) { | |||
There was a problem hiding this comment.
this test is included in the test case bellow: lint summary - lint error, thus I deleted it
ronenlu
force-pushed
the
code_suggestions
branch
from
54339da to
46f5f9a
Compare
ronenlu
force-pushed
the
code_suggestions
branch
from
46f5f9a to
f6911e5
Compare
a8m
approved these changes
Feb 19, 2024
ronenlu
added a commit
that referenced
this pull request
Feb 19, 2024
* update atlas-go-sdk * small refactor of code * add code suggestion function * test commit * fix test * update tests * update atlas go sdk verison * temp * update atlas sdk * fix tests * small fixes * fix test * add suggestion message to comment * add logic to upsert review comments * update tests * change notice to warning on check annotations * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: