Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/controller: support custom atlas.hcl #244

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datdao
Copy link
Member

@datdao datdao commented Dec 11, 2024

No description provided.

@datdao datdao force-pushed the d/custom-atlas-config branch from 30dc706 to 2ad336e Compare December 12, 2024 10:27

// GetVars returns the input variables for the project configuration.
// The variables are resolved from the secret or configmap reference.
func (s ProjectConfigSpec) GetVars(ctx context.Context, r client.Reader, namespace string) (atlasexec.Vars2, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func (s ProjectConfigSpec) GetVars(ctx context.Context, r client.Reader, namespace string) (atlasexec.Vars2, error) {
func (s ProjectConfigSpec) GetVars(ctx context.Context, r client.Reader, ns string) (atlasexec.Vars2, error) {

@datdao datdao force-pushed the d/custom-atlas-config branch 2 times, most recently from 76df2c7 to 56e9919 Compare December 13, 2024 10:55
@datdao datdao force-pushed the d/custom-atlas-config branch from 56e9919 to 261ba24 Compare December 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants