use dynaminc imports to not require unnecessary deps #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseelch
reviewed
Jun 11, 2024
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def has_native_uuid_field(self): |
There was a problem hiding this comment.
This is besically checking if the mysql driver is 8 or lower, right?
There was a problem hiding this comment.
This is true, but In order to determine the mysql version I need to call the DB (what I cannot do). so I mock this method
There was a problem hiding this comment.
We should think about maybe adding the target version to the query string / arguments in addition to the dialect
There was a problem hiding this comment.
Thats good point, but lets discuss is in seperate PR
masseelch
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.