Skip to content

Commit

Permalink
Renamed 'email' column to 'email_address' in the 'users' table to dem…
Browse files Browse the repository at this point in the history
…onstrate a backward-incompatible change.
  • Loading branch information
GitHub Gen Changes committed Nov 12, 2024
1 parent 1549077 commit a07ac9b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions dirs/ecommerce/migrations/20241112131146.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- Modify "users" table
ALTER TABLE `users` DROP CHECK `users_chk_1`, ADD CONSTRAINT `users_chk_1` CHECK (regexp_like(`email_address`,_utf8mb4'^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$')), DROP COLUMN `email`, ADD COLUMN `email_address` varchar(255) NOT NULL, ADD UNIQUE INDEX `email_address` (`email_address`);

Check failure on line 2 in dirs/ecommerce/migrations/20241112131146.sql

View workflow job for this annotation

GitHub Actions / atlas

destructive changes detected

Dropping non-virtual column "email" (DS103) Details: https://atlasgo.io/lint/analyzers#DS103

Check failure on line 2 in dirs/ecommerce/migrations/20241112131146.sql

View workflow job for this annotation

GitHub Actions / atlas

data dependent changes detected

Adding a non-nullable "varchar" column "email_address" on table "users" without a default value implicitly sets existing rows with "" (MY101) Details: https://atlasgo.io/lint/analyzers#MY101
3 changes: 2 additions & 1 deletion dirs/ecommerce/migrations/atlas.sum
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
h1:mQ4os5dvdZVxq9ucRsiEYty95umfc04MMDQfT68e+VI=
h1:/9r4FymEqj6PfXOQjTlim5Jc3Nxiv3gErAIpTbdUVqM=
20230316085611.sql h1:br6W6LPEnnsejlz/7hRm9zthwStCzjN2vZkqVPxlmvo=
20230316090502.sql h1:GfeRjkSeoCt3JVRtLQNa/r50lRfpAPXS7AqTU2ZNFgY=
20230531091333_products_categories.sql h1:59q2M59dV5dJNv4Lyb2TAJz8V6HekgkLn9z4DoL98jA=
Expand Down Expand Up @@ -59,3 +59,4 @@ h1:mQ4os5dvdZVxq9ucRsiEYty95umfc04MMDQfT68e+VI=
20241105131055.sql h1:Pa43oRSXYgYlTyRPmz+ifOUdjC37MBxXty/y6GLCaqk=
20241107131023.sql h1:ZCiG0I6S1KZRirv89U4894V9ZBuG6ChLYDuPyWC098c=
20241110130904.sql h1:qRQ+S6KPxiFyp8VxRMkZIFVop3rO1qrS3EJpKz2gjhw=
20241112131146.sql h1:jr03WRQUeJi4bfjc0zlDXaq7D+AlZPYaY4YbKE5TalA=
6 changes: 3 additions & 3 deletions dirs/ecommerce/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
CREATE TABLE `users` (
`id` int NOT NULL COMMENT 'Unique identifier for each user',
`user_name` varchar(255) NOT NULL COMMENT 'The username of the user, must be unique',
`email` varchar(255) NOT NULL,
`email_address` varchar(255) NOT NULL,
`phone_number` varchar(15) NOT NULL,
`country_code` varchar(5) NOT NULL DEFAULT '+1' COMMENT 'Country code for the phone number, defaults to US',
`is_admin` bool NULL DEFAULT 0 COMMENT 'Flag indicating if the user is an admin, defaults to false',
Expand All @@ -17,10 +17,10 @@ CREATE TABLE `users` (
`phone_verified` bool NOT NULL DEFAULT 0 COMMENT 'Flag indicating if the user phone number is verified, defaults to false',
`deleted_at` timestamp NULL COMMENT 'Timestamp for soft deletion of the user record',
PRIMARY KEY (`id`),
UNIQUE INDEX `email` (`email`),
UNIQUE INDEX `email_address` (`email_address`),
UNIQUE INDEX `user_name` (`user_name`),
UNIQUE INDEX `phone_number` (`phone_number`),
CHECK (`email` REGEXP '^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$'),
CHECK (`email_address` REGEXP '^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$'),
CHECK (`phone_number` REGEXP '^[0-9]{1,15}$')
) CHARSET utf8mb4 COLLATE utf8mb4_0900_ai_ci COMMENT 'Table storing user information, including authentication and profile details';

Expand Down

0 comments on commit a07ac9b

Please sign in to comment.