Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dirs/ecommerce: add sql comments #102

Merged
merged 2 commits into from
Oct 22, 2024
Merged

dirs/ecommerce: add sql comments #102

merged 2 commits into from
Oct 22, 2024

Conversation

marakomer
Copy link
Contributor

added comments to ecommerce mysql schema

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

atlas migrate lint on dirs/ecommerce/migrations

Status Step Result
1 new migration file detected 20241022103333_add_comments.sql
ERD and visual diff generated View Visualization
No issues found View Report
Read the full linting report on Atlas Cloud

@marakomer marakomer requested a review from ronenlu October 22, 2024 10:36
ronenlu
ronenlu approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@ronenlu ronenlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marakomer marakomer merged commit f71d631 into master Oct 22, 2024
1 check passed
@marakomer marakomer deleted the omert/add-comments-ecommerce branch October 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenlu ronenlu ronenlu approved these changes

@noamcattan noamcattan Awaiting requested review from noamcattan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marakomer @ronenlu