provider: support docker as dev-url (#64)

* provider: support docker as dev-url Signed-off-by: Giau. Tran Minh <[email protected]> * chore: fixed lint Signed-off-by: Giau. Tran Minh <[email protected]> --------- Signed-off-by: Giau. Tran Minh <[email protected]>
ariga · Apr 20, 2023 · c983b10 · c983b10
1 parent ae1e34e
commit c983b10
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,10 @@ terraform {
     }
   }
 }
-provider "atlas" {}
+provider "atlas" {
+  # Use MySQL 8 docker image as the dev database.
+  dev_url = "docker://mysql/8"
+}
 ```
 
 ## Quick Start

diff --git a/docs/index.md b/docs/index.md
@@ -15,11 +15,13 @@ For documentation about Atlas, visit: https://atlasgo.io
 ## Example Usage
 
 ```terraform
-provider "atlas" {}
+provider "atlas" {
+  # Use MySQL 8 docker image as the dev database.
+  dev_url = "docker://mysql/8/market"
+}
 
 data "atlas_schema" "market" {
-  dev_url = "mysql://root:pass@localhost:3307/market"
-  src     = file("${path.module}/schema.hcl")
+  src = file("${path.module}/schema.hcl")
 }
 
 resource "atlas_schema" "market" {

diff --git a/examples/provider/provider.tf b/examples/provider/provider.tf
@@ -1,8 +1,10 @@
-provider "atlas" {}
+provider "atlas" {
+  # Use MySQL 8 docker image as the dev database.
+  dev_url = "docker://mysql/8/market"
+}
 
 data "atlas_schema" "market" {
-  dev_url = "mysql://root:pass@localhost:3307/market"
-  src     = file("${path.module}/schema.hcl")
+  src = file("${path.module}/schema.hcl")
 }
 
 resource "atlas_schema" "market" {

diff --git a/internal/atlas/atlas.go b/internal/atlas/atlas.go
@@ -196,7 +196,10 @@ func (c *Client) Status(ctx context.Context, data *StatusParams) (*StatusReport,
 // interface.
 func (c *Client) runCommand(ctx context.Context, args []string, report interface{}) (string, error) {
 	cmd := exec.CommandContext(ctx, c.path, args...)
-	cmd.Env = append(cmd.Env, "ATLAS_NO_UPDATE_NOTIFIER=1")
+	cmd.Env = append(cmd.Env,
+		"ATLAS_NO_UPDATE_NOTIFIER=1",
+		fmt.Sprintf("PATH=%s", os.Getenv("PATH")),
+	)
 	output, err := cmd.Output()
 	if err != nil {
 		exitErr, ok := err.(*exec.ExitError)