Changes applied in Gentoo as patches-1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 will not allow implicit ints, implicit function declarations etc. by default. This patch overhauls to whole package source to make it build with clang16. It also gets rid of old K&R style function declaration. Bug: https://bugs.gentoo.org/861830 Bug: https://bugs.gentoo.org/870940 Signed-off-by: Pascal Jäger <[email protected]> Upstream-PR: arineng#2
Prevent build to directly call ar and use a variable instead. Bug: https://bugs.gentoo.org/725194 Signed-off-by: Pascal Jäger <[email protected]>
The __sighandler_t is glibc thing. It is not needed to explicitly retype then if all signal handlers will return void, which is expected callback return type in Linux or BSDs. Bug: https://bugs.gentoo.org/924504 Signed-off-by: Petr Vaněk <[email protected]>
Otherwise it could end up badly or even ugly, see the linked bug. Bug: https://bugs.gentoo.org/927273 Signed-off-by: Petr Vaněk <[email protected]>
Glibc-2.1 is ancient version (1999-02-03), we don't have to care about older versions anymore. The check removal makes it easier for musl libc. Bug: https://bugs.gentoo.org/715310 Signed-off-by: Petr Vaněk <[email protected]>
Signed-off-by: Petr Vaněk <[email protected]>
bool is a keyword since C23, modern GCC emits errors when it is used as an argument name. Bug: https://bugs.gentoo.org/943795 Signed-off-by: Petr Vaněk <[email protected]>
This commit updates the usage of the destroy callback function to use the new dl_destroy_fn typedef. Explicit casting to dl_destroy_fn is added in calls to dl_list_default to address type mismatches, which are problematic with modern GCC. Bug: https://bugs.gentoo.org/943795 Signed-off-by: Petr Vaněk <[email protected]>
Explicitly include stdlib.h and string.h to provide a proper declaration for malloc and strncpy. Bug: https://bugs.gentoo.org/943795 Signed-off-by: Petr Vaněk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves files to the root of the repo as suggested in #1, rebases #2 to the moved files, applies some other changes used in Gentoo but it resolves the issue from PR #3 differently, plus few more changes necessary for Gentoo.