-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cv_validate_v3 broken with cvprac 1.4.0 due to argument keyword change #694
Fix: cv_validate_v3 broken with cvprac 1.4.0 due to argument keyword change #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and worked fine testing in a production environment.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
cvprac updated the keyword arguments for
validate_config_for_device()
fromdevice_mac
todev_mac
in aristanetworks/cvprac@69fd313#diff-ff77c7a073e87f20dd555db78c0b2ee12ed8924d0cc12645fb2e33034ec523aaL1359 and playbooks are failing with:Thanks for @pmprado for reporting
Related Issue(s)
Fixes #
Component(s) name
arista.cvp.cv_validate_v3
Proposed changes
removed the keyword argument name and just passing the vars
How to test
Checklist
User Checklist
Repository Checklist