Skip to content

Commit

Permalink
fix(anta.reporter): Define constants to manage table headers - sonarc…
Browse files Browse the repository at this point in the history
…loud
  • Loading branch information
titom73 committed Jul 5, 2024
1 parent 4e16158 commit 13a6b48
Showing 1 changed file with 19 additions and 22 deletions.
41 changes: 19 additions & 22 deletions anta/reporter/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Headers(BaseModel):
"""Headers for the table report."""

device: str = "Device"
test_case: str = "Test Case"
test_case: str = "Test Name"
number_of_success: str = "# of success"
number_of_failure: str = "# of failure"
number_of_skipped: str = "# of skipped"
Expand Down Expand Up @@ -75,9 +75,6 @@ def _build_headers(self, headers: list[str], table: Table) -> Table:
for idx, header in enumerate(headers):
if idx == 0:
table.add_column(header, justify="left", style=RICH_COLOR_PALETTE.HEADER, no_wrap=True)
elif header == "Test Name":
# We always want the full test name
table.add_column(header, justify="left", no_wrap=True)
else:
table.add_column(header, justify="left")
return table
Expand Down Expand Up @@ -148,12 +145,12 @@ def report_summary_tests(
"""
table = Table(title=title, show_lines=True)
headers = [
self.Headers.test_case,
self.Headers.number_of_success,
self.Headers.number_of_skipped,
self.Headers.number_of_failure,
self.Headers.number_of_errors,
self.Headers.list_of_error_nodes,
self.Headers().test_case,
self.Headers().number_of_success,
self.Headers().number_of_skipped,
self.Headers().number_of_failure,
self.Headers().number_of_errors,
self.Headers().list_of_error_nodes,
]
table = self._build_headers(headers=headers, table=table)
for test in manager.get_tests():
Expand Down Expand Up @@ -196,12 +193,12 @@ def report_summary_devices(
"""
table = Table(title=title, show_lines=True)
headers = [
self.Headers.device,
self.Headers.number_of_success,
self.Headers.number_of_skipped,
self.Headers.number_of_failure,
self.Headers.number_of_errors,
self.Headers.list_of_error_tests,
self.Headers().device,
self.Headers().number_of_success,
self.Headers().number_of_skipped,
self.Headers().number_of_failure,
self.Headers().number_of_errors,
self.Headers().list_of_error_tests,
]
table = self._build_headers(headers=headers, table=table)
for device in manager.get_devices():
Expand Down Expand Up @@ -321,12 +318,12 @@ def add_line(result: TestResult) -> list[str]:
]

headers = [
self.Headers.device,
self.Headers.test_name,
self.Headers.test_status,
self.Headers.messages,
self.Headers.description,
self.Headers.categories,
self.Headers().device,
self.Headers().test_name,
self.Headers().test_status,
self.Headers().messages,
self.Headers().description,
self.Headers().categories,
]

with pathlib.Path.open(csv_filename, "w", encoding="utf-8") as csvfile:
Expand Down

0 comments on commit 13a6b48

Please sign in to comment.