Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta): Refactor AntaTestCommand and AntaTestTemplate #245

Merged
merged 25 commits into from
Jul 6, 2023
Merged

refactor(anta): Refactor AntaTestCommand and AntaTestTemplate #245

merged 25 commits into from
Jul 6, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Jul 4, 2023 •
edited
Loading

AntaCommand

  • refactor(anta.models): rename AntaTestCommand to AntaCommand
  • feat(anta.models): propagate error in AntaCommand object
  • add collected property to AntaCommand

AntaTemplate

  • refactor(anta.models): Rename AntaTestTemplate to AntaTemplate
  • refactor(anta.models): introduce AntaTemplate.render()

Others

  • Update tests to reflect AntaCommand and AntaTemplate changes
  • Use rich tracebacks
  • Create a specific logger for each test class

This was linked to issues Jul 5, 2023
ValueError when devices have ReadTimeout #231
Closed
Remove need for cast in tests by refactoring AntaTestCommand class #240
Closed
@mtache mtache marked this pull request as ready for review July 6, 2023 11:50
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

mtache added 18 commits July 6, 2023 15:09
@mtache
refactor(anta.models): rename AntaTestCommand to AntaCommand
cb4107e
@mtache
refactor(anta.models): Rename AntaTestTemplate to AntaTemplate
cef89bb
@mtache
refactor(anta.models): introduce AntaTemplate.render()
e2406b6
@mtache
AntaTestCommand has been renamed
214f7a8
@mtache
fix(anta.models): add template attribute to AntaCommand
0ce67f4
@mtache
Instantiate AntaTemplate objects from parameters
cf3a94c
@mtache
Update tests for new AntaTemplate rendering
20e72c8
@mtache
feat(anta.models): propagate error in AntaCommand object
708b96b
@mtache
add collected property to AntaCommand
91ef675
@mtache
isort
cdcd201
@mtache
make output attribute private in AntaCommand
0609f83
@mtache
linting/clean
d482b25
@mtache
use rich tracebacks
73bdbbe
@mtache
output attribute is finally public and params are now an attribute of…
2c782af 
… AntaCommand
@mtache
linting
ba133a8
@mtache
create a specific logger for each test class
46c42c0
@mtache
Remove cast() in all tests
aa05196
@mtache
update MLAG tests
76f0ae0
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtache mtache merged commit f887ebe into aristanetworks:master Jul 6, 2023
15 checks passed
@mtache mtache deleted the refactor/AntaCommand branch July 7, 2023 09:50
@gmuloc gmuloc mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc Awaiting requested review from gmuloc

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

@titom73 titom73 Awaiting requested review from titom73

Assignees

@mtache mtache

Labels
rn: refactor(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove need for cast in tests by refactoring AntaTestCommand class ValueError when devices have ReadTimeout
1 participant
@mtache