refactor: Remove dependency on netaddr #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtache
reviewed
Jul 11, 2023
anta/inventory/__init__.py
Outdated
| @@ -42,6 +41,81 @@ def __str__(self) -> str: | |||
| devs[dev_type] += 1 | |||
| return f"ANTA Inventory contains {' '.join([f'{n} devices ({t})' for t, n in devs.items()])}" | |||
|
|
|||
| @staticmethod | |||
| def __parse_hosts(inventory_input: AntaInventoryInput, inventory: AntaInventory, **kwargs: Any) -> None: | |||
There was a problem hiding this comment.
Is mangling necessary ?
Maybe _parse_hosts() is enough.
anta/inventory/__init__.py
Outdated
| inventory.add_device(device) | ||
|
|
||
| @staticmethod | ||
| def __parse_networks(inventory_input: AntaInventoryInput, inventory: AntaInventory, **kwargs: Any) -> None: |
anta/inventory/__init__.py
Outdated
| raise InventoryIncorrectSchema(message) from e | ||
|
|
||
| @staticmethod | ||
| def __parse_ranges(inventory_input: AntaInventoryInput, inventory: AntaInventory, **kwargs: Any) -> None: |
|
Works on my machine. |
titom73
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Refactor: Remove dependency on netaddr * Refactor: Unmangling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253