Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added the test case to verify the Entropy source security #780

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat(anta): Added the test case to verify the Entropy source security #780

merged 2 commits into from
Aug 21, 2024

Conversation

vitthalmagadum
Copy link
Contributor

Description

Verifies hardware entropy generation is enabled on device.

Expected Results
----------------
* Success: The test will pass if hardware entropy generation is enabled.
* Failure: The test will fail if hardware entropy generation is not enabled.

Fixes #768

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft August 7, 2024 08:38
MaheshGSLAB
MaheshGSLAB reviewed Aug 8, 2024
View reviewed changes
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MaheshGSLAB
MaheshGSLAB approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 16, 2024 05:33
carl-baillargeon
carl-baillargeon approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 61e206e into aristanetworks:main Aug 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the Entropy source security
3 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB