Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added test case to verify Inbound route map and Outbound route map in BGP neighbor details #793

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

vitthalmagadum
Copy link
Contributor

Description

Verifies BGP Inbound Outbound route-maps of BGP IPv4 peer(s).

Checks whether the correct route maps are applied in the correct direction
(inbound or outbound) on the specified IPv4 BGP neighbors.

Expected Results
----------------
* Success: The test will pass if the route map names applied on each neighbor match the expected configuration.
* Failure: The test will fail if BGP peers are not configured or any neighbor has an incorrect or missing route map in either the inbound or outbound direction.

Fixes #785

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/routing/test_bgp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/routing/test_bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/routing/test_bgp.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Sep 17, 2024

@carl-baillargeon carl-baillargeon merged commit 900ebb7 into aristanetworks:main Sep 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case to verify Inbound route map and Outbound route map in BGP neighbor details
3 participants