Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added merge_catalogs function #802

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Aug 26, 2024

Description

  • Added merge_catalogs function to the catalog.py module.
  • Updated AntaCatalog.merge to use that function.

Fixes #715

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

anta/catalog.py Outdated Show resolved Hide resolved
docs/usage-inventory-catalog.md Outdated Show resolved Hide resolved
tests/units/test_catalog.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 27, 2024

@carl-baillargeon carl-baillargeon merged commit 484275d into aristanetworks:main Aug 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve AntaCatalog merge function
2 participants