Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Enable D417 for ruff on top of numpy and fix asynceapi #829

Merged
merged 7 commits into from
Sep 18, 2024
Merged

doc: Enable D417 for ruff on top of numpy and fix asynceapi #829

merged 7 commits into from
Sep 18, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Sep 13, 2024

Description

cf title

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

gmuloc
gmuloc commented Sep 16, 2024
View reviewed changes
asynceapi/device.py Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Sep 16, 2024
View reviewed changes
asynceapi/device.py Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Sep 16, 2024
View reviewed changes
asynceapi/config_session.py Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Sep 16, 2024
View reviewed changes
asynceapi/config_session.py Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Sep 18, 2024
View reviewed changes
asynceapi/device.py Outdated Show resolved Hide resolved
gmuloc
gmuloc commented Sep 18, 2024
View reviewed changes
asynceapi/device.py Outdated Show resolved Hide resolved
@gmuloc gmuloc changed the title doc: Enable D417 for ruff on top of numpy and fix asyneapi doc: Enable D417 for ruff on top of numpy and fix asynceapi Sep 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mtache mtache merged commit ecef2b7 into aristanetworks:main Sep 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtache mtache mtache approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmuloc @mtache