Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove final-tests-counts from catalog, have dry-run work as expected #840

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Sep 30, 2024

Description

  1. AntaCatalog.final_tests_counts was not working correctly when reusing a catalog multiple time in a runner
  2. --dry-run command is expected to return a ResultManager with all the "would-be-run" tests with a status of unset.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Refactor: Remove final-tests-counts from catalog, have dry-run work as expected refactor: Remove final-tests-counts from catalog, have dry-run work as expected Sep 30, 2024
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 4 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_anta[1 device] (1 s)
  • test_anta[2 devices] (2 s)
  • test_anta_dry_run[1 device] (69.9 ms)
  • test_anta_dry_run[2 devices] (125.9 ms)

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtache mtache merged commit 3408217 into aristanetworks:main Sep 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants