-
Notifications
You must be signed in to change notification settings - Fork 203
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor(plugins): Move jinja filter code for arista.avd.generate_lac…
…p_id to PyAVD (#4139)
- Loading branch information
1 parent
e961e9f
commit 384047b
Showing
11 changed files
with
74 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
ansible_collections/arista/avd/tests/unit/filters/test_esi_management.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Copyright (c) 2023-2024 Arista Networks, Inc. | ||
# Use of this source code is governed by the Apache License 2.0 | ||
# that can be found in the LICENSE file. | ||
from __future__ import annotations | ||
|
||
|
||
def generate_lacp_id(esi_short: str) -> str: | ||
""" | ||
Transforms short_esi `0303:0202:0101` to LACP ID format `0303.0202.0101` | ||
Args: | ||
esi_short (str): Short ESI value as per AVD definition in eos_designs | ||
Returns: | ||
str: LACP ID | ||
""" | ||
return esi_short.replace(":", ".") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Copyright (c) 2023-2024 Arista Networks, Inc. | ||
# Use of this source code is governed by the Apache License 2.0 | ||
# that can be found in the LICENSE file. | ||
import pytest | ||
from pyavd.j2filters.generate_lacp_id import generate_lacp_id | ||
|
||
ESI_SHORT_VALID_INPUT = [ | ||
("0404:0202:0101", "0404.0202.0101"), | ||
("000:000:0303:0202:0101", "000.000.0303.0202.0101"), | ||
("", ""), | ||
] | ||
|
||
ESI_SHORT_INVALID_INPUT = [ | ||
(10, "'int' object has no attribute 'replace'"), | ||
(None, "'NoneType' object has no attribute 'replace'"), | ||
({}, "'dict' object has no attribute 'replace'"), | ||
([], "'list' object has no attribute 'replace'"), | ||
] | ||
|
||
|
||
class TestGenerateLacpIdFilter: | ||
|
||
@pytest.mark.parametrize("esi_short, lacp_id", ESI_SHORT_VALID_INPUT) | ||
def test_generate_lacp_id_valid(self, esi_short, lacp_id): | ||
resp = generate_lacp_id(esi_short) | ||
assert resp == lacp_id | ||
|
||
@pytest.mark.parametrize("esi_short, error_msg", ESI_SHORT_INVALID_INPUT) | ||
def test_generate_lacp_id_invalid(self, esi_short, error_msg): | ||
with pytest.raises(AttributeError) as exc_info: | ||
generate_lacp_id(esi_short) | ||
assert str(exc_info.value) == error_msg |