Merge branch 'devel' into feat/ethernet_interfaces/isis_auth

.github/workflows/pull-request-management.yml

@@ -458,7 +458,7 @@ jobs:
         # The version conflicts with our requirements,
         # so we let the galaxy-importer version resolve remaining requirements.
         run: |
-          pip install "galaxy-importer==0.4.22"
+          pip install "galaxy-importer==0.4.25"
       - name: 'Build ansible package'
         run: make collection-build
       - name: 'Run galaxy-importer checks'

ansible_collections/arista/avd/docs/porting-guides/5.x.x.md

@@ -391,6 +391,40 @@ The description can be reverted manually if needed:
 +vtep_loopback_description: "VTEP_VXLAN_Tunnel_Source"
 ```
 
+#### Underlay point-to-point L3 ethernet interfaces
+
+The interface description for the L3 point-to-point interfaces changes to `P2P_<peer>_<peer_interface>_VRF_<vrf>`. Previously the description was `P2P_LINK_TO_<peer | upper>_<peer_interface>_vrf_<vrf>`. The VRF suffix is only added when using `uplink_type: p2p-vrfs`.
+
+The interfaces using this are routed uplinks and `p2p_links` defined under `l3_edge` or `core_interfaces`.
+
+Setting the description directly on `p2p_links` defined under `l3_edge` or `core_interfaces` still takes precedence.
+
+The default descriptions can be reverted manually if needed:
+
+```diff
++default_underlay_p2p_ethernet_description: "P2P_LINK_TO_{peer!u}_{peer_interface}{vrf?<_vrf_}"
+```
+
+The description fields support templates. See the input variables documentation for available fields.
+
+#### Underlay point-to-point L3 port-channel interfaces
+
+The interface description for the L3 point-to-point port-channels changes to `P2P_<peer>_<peer_interface>`. Previously the default description was `P2P_LINK_TO_<peer>_<peer_interface>`.
+
+The port-channels using this are `p2p_links` defined under `l3_edge` or `core_interfaces`.
+
+Setting the description directly on `p2p_links` defined under `l3_edge` or `core_interfaces` still takes precedence.
+
+In AVD 5.0.0 it is also possible to control the port-channel description separately by setting the `description` key under `port_channel`. It will replace the full port-channel interface description.
+
+The default descriptions can be reverted manually if needed:
+
+```diff
++default_underlay_p2p_port_channel_description: "P2P_LINK_TO_{peer}_{peer_interface}"
+```
+
+The description fields support templates. See the input variables documentation for available fields.
+
 #### Out-of-band management interface
 
 The default interface description for the management interface changes to `OOB_MANAGEMENT`.
@@ -502,6 +536,106 @@ The description can be reverted manually if needed:
 +mlag_port_channel_description: "MLAG_PEER_{mlag_peer}_Po{mlag_port_channel_id}"
 ```
 
+#### MLAG peer VLAN interface
+
+The interface description for the MLAG peer SVI changes to `MLAG`. Previously the description was `MLAG_PEER`.
+
+The description can be reverted manually if needed:
+
+```diff
++mlag_peer_svi_description: "MLAG_PEER"
+```
+
+The description setting supports a template. See the input variables documentation for available fields.
+
+#### MLAG L3 peering VLAN interface
+
+The interface description for the MLAG L3 peering SVI changes to `MLAG_L3`. Previously the description was `MLAG_PEER_L3_PEERING`.
+
+The description can be reverted manually if needed:
+
+```diff
++mlag_peer_l3_svi_description: "MLAG_PEER_L3_PEERING"
+```
+
+The description setting supports a template. See the input variables documentation for available fields.
+
+#### MLAG L3 VRF peering VLAN interface
+
+The interface description for the MLAG L3 VRF peering SVI changes to `MLAG_L3_VRF_{vrf}`. Previously the description was `MLAG_PEER_L3_iBGP: vrf {vrf}`.
+
+The description can be reverted manually if needed:
+
+```diff
++mlag_peer_l3_vrf_svi_description: "MLAG_PEER_L3_iBGP: vrf {vrf}"
+```
+
+The description setting supports a template. See the input variables documentation for available fields.
+
+### Default VLAN names are changed for more consistency
+
+#### MLAG peer VLAN
+
+The name of the MLAG peer VLAN (VLAN 4094 by default) changes to `MLAG`. Previously the name was `MLAG_PEER`.
+
+The name can be reverted manually if needed:
+
+```diff
++mlag_peer_vlan_name: "MLAG_PEER"
+```
+
+The setting supports a template. See the input variables documentation for available fields.
+
+#### MLAG L3 peering VLAN
+
+The name of the MLAG L3 peering VLAN (VLAN 4093 by default) changes to `MLAG_L3`. Previously the name was `LEAF_PEER_L3`.
+
+The name can be reverted manually if needed:
+
+```diff
++mlag_peer_l3_vlan_name: "LEAF_PEER_L3"
+```
+
+The setting supports a template. See the input variables documentation for available fields.
+
+#### MLAG L3 VRF peering VLAN
+
+The name of the MLAG L3 VRF peering VLAN changes to `MLAG_L3_VRF_{vrf}`. Previously the name was `MLAG_iBGP_{vrf}`.
+
+The name can be reverted manually if needed:
+
+```diff
++mlag_peer_l3_vrf_vlan_name: "MLAG_iBGP_{vrf}"
+```
+
+The setting supports a template. See the input variables documentation for available fields.
+
+### Default BGP peer descriptions are changed for more consistency
+
+#### MLAG L3 peering
+
+The description of the MLAG L3 BGP peers, including those in VRFs, changes to `{mlag_peer}_{peer_interface}`. Previously the description was `{mlag_peer}`.
+
+The description can be reverted manually if needed:
+
+```diff
++mlag_bgp_peer_description: "{mlag_peer}"
+```
+
+The setting supports a template. See the input variables documentation for available fields.
+
+#### Overlay peerings
+
+The description of the overlay BGP peers (EVPN, MPLS, WAN) changes to `{peer}{peer_interface?<_}`. Previously the description was `{peer}`.
+
+The description can be reverted manually if needed:
+
+```diff
++overlay_bgp_peer_description: "{peer}"
+```
+
+The setting supports a template. See the input variables documentation for available fields.
+
 ### Combine the VLAN trunk groups used for MLAG
 
 With AVD version 5.0.0 a single `MLAG` trunk group is used for MLAG and MLAG L3 peerings, including the peerings in VRFs.
@@ -713,6 +847,44 @@ custom_platform_settings:
       - AWE-7220R
 ```
 
+#### Default encapsulation for WAN EVPN iBGP peerings changed to `path-selection`
+
+With AVD version 5.0.0 the default encapsulation used for EVPN iBGP peering between WAN routers is `path-selection`. Previously it was `vxlan`.
+
+!!! danger
+    The `path-selection` encapsulation is only supported on EOS above 4.33.0F.
+
+    It is critical that all WAN devices use the same encapsulation. For
+    existing deployments it is recommended to set the encapsulation back to
+    `vxlan` until a migration can be done across the entire WAN network.
+
+    Contact your Arista account team for guidance on migration.
+
+To retain the vxlan encapsulation on WAN EVPN iBGP peerings use `wan_encapsulation`:
+
+```diff
++ wan_encapsulation: vxlan
+```
+
+### PREVIEW WAN HA Direct Link now uses Port-Channel by default
+
+For WAN direct HA, AVD will now configure a port-channel by default. This feature was introduced in EOS 4.33.0F.
+
+To retain the previous configuration use custom_platform_settings use `use_port_channel_for_direct_ha: false` under `wan_ha`.
+
+```diff
+  wan_router:
+    node_groups:
+      - group: Site42
+        cv_pathfinder_region: AVD_Land_West
+        cv_pathfinder_site: Site42
+        wan_ha:
+          enabled: true
++         use_port_channel_for_direct_ha: false
+          ha_interfaces: [Ethernet52]
+          ha_ipv4_pool: 10.10.10.0/24
+```
+
 ## Changes to role `arista.avd.eos_cli_config_gen`
 
 TODO: Level 3 sections for each change with details on how to migrate

ansible_collections/arista/avd/docs/release-notes/5.x.x.md

@@ -206,12 +206,46 @@ The updated version gives more flexibility to customizing interface descriptions
 
 See the [Porting guide for AVD 5.x.x](../porting-guides/5.x.x.md#avdinterfacedescriptions-breaking-changes)
 
+#### Reference to a non-existing profile now raise an error
+
+With AVD version 5.0.0, if any referenced profile or parent profile is not defined, AVD will now raise an error. This helps catching typos in the input variables.
+
+This applies to:
+
+- `l3_interface_profiles`
+- `port_profiles`
+- `svi_profiles`
+
 #### `wan_mode: autovpn` renamed `wan_mode: legacy-autovpn`
 
 With AVD version 5.0.0 the valid values for `wan_mode` key are now `legacy-autovpn | cv-pathfinder`.
 
 See the [porting guide](../porting-guides/5.x.x.md#wan-mode-autovpn-renamed-wan-mode-legacy-vpn) for details.
 
+#### Default encapsulation for WAN EVPN iBGP peerings changed to `path-selection`
+
+With AVD version 5.0.0 the default encapsulation used for EVPN iBGP peering between WAN routers is `path-selection`. Previously it was `vxlan`.
+
+!!! danger
+    The `path-selection` encapsulation is only supported on EOS above 4.33.0F.
+
+    It is critical that all WAN devices use the same encapsulation. For
+    existing deployments it is recommended to set the encapsulation back to
+    `vxlan` until a migration can be done across the entire WAN network.
+
+    Contact your Arista account team for guidance on migration.
+
+See the [porting guide](../porting-guides/5.x.x.md#default-encapsulation-for-wan-evpn-ibgp-peerings-changed-to-path-selection) for details.
+
+#### PREVIEW WAN HA Direct Link now uses Port-Channel by default
+
+TODO: Keep PREVIEW changes at the end as we warn users that PREVIEW mean changes
+
+For WAN direct HA, AVD will now configure a port-channel by default.
+This feature was introduced recently in EOS and may not be supported on your version.
+
+See the [porting guide](../porting-guides/5.x.x.md#preview-wan-ha-direct-link-now-uses-port-channel-by-default) for details.
+
 ### Other breaking or behavioral changes
 
 Breaking changes may require modifications to the inventory or playbook. See the [Porting guide for AVD 5.x.x](../porting-guides/5.x.x.md)

ansible_collections/arista/avd/examples/campus-fabric/documentation/devices/LEAF1A.md

@@ -248,7 +248,7 @@ vlan internal order ascending range 1006 1199
 | 110 | IDF1-Data | - |
 | 120 | IDF1-Voice | - |
 | 130 | IDF1-Guest | - |
-| 4094 | MLAG_PEER | MLAG |
+| 4094 | MLAG | MLAG |
 
 ### VLANs Device Configuration
 
@@ -267,7 +267,7 @@ vlan 130
    name IDF1-Guest
 !
 vlan 4094
-   name MLAG_PEER
+   name MLAG
    trunk group MLAG
 ```
 
@@ -1406,7 +1406,7 @@ interface Port-Channel53
 | Interface | Description | VRF |  MTU | Shutdown |
 | --------- | ----------- | --- | ---- | -------- |
 | Vlan10 | Inband Management | default | 1500 | False |
-| Vlan4094 | MLAG_PEER | default | 1500 | False |
+| Vlan4094 | MLAG | default | 1500 | False |
 
 ##### IPv4
 
@@ -1426,7 +1426,7 @@ interface Vlan10
    ip address 10.10.10.6/24
 !
 interface Vlan4094
-   description MLAG_PEER
+   description MLAG
    no shutdown
    mtu 1500
    no autostate

ansible_collections/arista/avd/examples/campus-fabric/documentation/devices/LEAF1B.md

@@ -248,7 +248,7 @@ vlan internal order ascending range 1006 1199
 | 110 | IDF1-Data | - |
 | 120 | IDF1-Voice | - |
 | 130 | IDF1-Guest | - |
-| 4094 | MLAG_PEER | MLAG |
+| 4094 | MLAG | MLAG |
 
 ### VLANs Device Configuration
 
@@ -267,7 +267,7 @@ vlan 130
    name IDF1-Guest
 !
 vlan 4094
-   name MLAG_PEER
+   name MLAG
    trunk group MLAG
 ```
 
@@ -1406,7 +1406,7 @@ interface Port-Channel53
 | Interface | Description | VRF |  MTU | Shutdown |
 | --------- | ----------- | --- | ---- | -------- |
 | Vlan10 | Inband Management | default | 1500 | False |
-| Vlan4094 | MLAG_PEER | default | 1500 | False |
+| Vlan4094 | MLAG | default | 1500 | False |
 
 ##### IPv4
 
@@ -1426,7 +1426,7 @@ interface Vlan10
    ip address 10.10.10.7/24
 !
 interface Vlan4094
-   description MLAG_PEER
+   description MLAG
    no shutdown
    mtu 1500
    no autostate

ansible_collections/arista/avd/examples/campus-fabric/documentation/devices/LEAF3A.md

@@ -248,7 +248,7 @@ vlan internal order ascending range 1006 1199
 | 310 | IDF3-Data | - |
 | 320 | IDF3-Voice | - |
 | 330 | IDF3-Guest | - |
-| 4094 | MLAG_PEER | MLAG |
+| 4094 | MLAG | MLAG |
 
 ### VLANs Device Configuration
 
@@ -267,7 +267,7 @@ vlan 330
    name IDF3-Guest
 !
 vlan 4094
-   name MLAG_PEER
+   name MLAG
    trunk group MLAG
 ```
 
@@ -2513,7 +2513,7 @@ interface Port-Channel983
 | Interface | Description | VRF |  MTU | Shutdown |
 | --------- | ----------- | --- | ---- | -------- |
 | Vlan10 | Inband Management | default | 1500 | False |
-| Vlan4094 | MLAG_PEER | default | 1500 | False |
+| Vlan4094 | MLAG | default | 1500 | False |
 
 ##### IPv4
 
@@ -2533,7 +2533,7 @@ interface Vlan10
    ip address 10.10.10.9/24
 !
 interface Vlan4094
-   description MLAG_PEER
+   description MLAG
    no shutdown
    mtu 1500
    no autostate

ansible_collections/arista/avd/examples/campus-fabric/documentation/devices/LEAF3B.md

@@ -248,7 +248,7 @@ vlan internal order ascending range 1006 1199
 | 310 | IDF3-Data | - |
 | 320 | IDF3-Voice | - |
 | 330 | IDF3-Guest | - |
-| 4094 | MLAG_PEER | MLAG |
+| 4094 | MLAG | MLAG |
 
 ### VLANs Device Configuration
 
@@ -267,7 +267,7 @@ vlan 330
    name IDF3-Guest
 !
 vlan 4094
-   name MLAG_PEER
+   name MLAG
    trunk group MLAG
 ```
 
@@ -2513,7 +2513,7 @@ interface Port-Channel983
 | Interface | Description | VRF |  MTU | Shutdown |
 | --------- | ----------- | --- | ---- | -------- |
 | Vlan10 | Inband Management | default | 1500 | False |
-| Vlan4094 | MLAG_PEER | default | 1500 | False |
+| Vlan4094 | MLAG | default | 1500 | False |
 
 ##### IPv4
 
@@ -2533,7 +2533,7 @@ interface Vlan10
    ip address 10.10.10.10/24
 !
 interface Vlan4094
-   description MLAG_PEER
+   description MLAG
    no shutdown
    mtu 1500
    no autostate