Skip to content

Commit

Permalink
Fix(eos_designs): Incorect type for bpg remote_as (#3313)
Browse files Browse the repository at this point in the history
  • Loading branch information
carlbuchmann authored Nov 3, 2023
1 parent 28033bb commit 86cac32
Show file tree
Hide file tree
Showing 18 changed files with 88 additions and 87 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ router_bgp:
peer_groups:
EVPN-OVERLAY-PEERS:
type: evpn
remote_as: 65001
remote_as: "65001"
update_source: Loopback0
# Testing peer_filter & bgp_listen_range_prefix which were deprecated in 4.0.0. To be removed in 5.0.0
peer_filter: myfilter
Expand All @@ -25,7 +25,7 @@ router_bgp:
neighbor_interfaces:
Ethernet2:
peer_group: EVPN-OVERLAY-PEERS
remote_as: 65102
remote_as: "65102"
address_family_ipv4:
# Testing neighbors as dict of dict
# Dict type is deprecated in 4.0.0. To be removed in 5.0.0
Expand Down Expand Up @@ -161,7 +161,7 @@ router_bgp:
neighbor_interfaces:
Ethernet27:
peer_group: MLAG-IPv4-UNDERLAY-PEER
remote_as: 1
remote_as: "1"
# Testing address_families as dict of dict
# Dict type is deprecated in 4.0.0. To be removed in 5.0.0
# address_families itself is deprecated in 4.0.0. To be removed in 5.0.0.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ tenants:
TENANT_B:
bgp_peer_groups:
Tenant_C_BGP_PEER_GROUP:
remote_as: 666
remote_as: "666"
description: "Tenant C peer group"
send_community: all
next_hop_self: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ router bgp 65104
neighbor 123.1.1.10 update-source Loopback123
neighbor 123.1.1.10 route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT out
neighbor 123.1.1.10 route-map RM-123-1-1-10-IN in
neighbor 123.1.1.11 remote-as 1234
neighbor 123.1.1.11 remote-as 65000.100
neighbor 123.1.1.11 password 7 oBztv71m2uhR7hh58/OCNA==
neighbor 123.1.1.11 local-as 123 no-prepend replace-as
neighbor 123.1.1.11 description External IPv4 BGP peer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ router bgp 65105
neighbor 123.1.1.10 update-source Loopback123
neighbor 123.1.1.10 route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT out
neighbor 123.1.1.10 route-map RM-123-1-1-10-IN in
neighbor 123.1.1.11 remote-as 1234
neighbor 123.1.1.11 remote-as 65000.100
neighbor 123.1.1.11 password 7 oBztv71m2uhR7hh58/OCNA==
neighbor 123.1.1.11 local-as 123 no-prepend replace-as
neighbor 123.1.1.11 description External IPv4 BGP peer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ router_bgp:
route_map_out: RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT
local_as: '123'
- ip_address: 123.1.1.11
remote_as: '1234'
remote_as: '65000.100'
password: oBztv71m2uhR7hh58/OCNA==
description: External IPv4 BGP peer
send_community: standard extended
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ router_bgp:
route_map_out: RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT
local_as: '123'
- ip_address: 123.1.1.11
remote_as: '1234'
remote_as: '65000.100'
password: oBztv71m2uhR7hh58/OCNA==
description: External IPv4 BGP peer
send_community: standard extended
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ tenant_a:
nodes: [DC1-BL1A, DC1-BL1B]
bgp_peers:
- ip_address: 123.1.1.10
remote_as: 1234
remote_as: "1234"
password: "oBztv71m2uhR7hh58/OCNA=="
description: External IPv4 BGP peer
send_community: standard extended
Expand All @@ -170,7 +170,7 @@ tenant_a:
route_map_out: RM-123-1-1-10-OUT
local_as: 123
- ip_address: 123.1.1.11
remote_as: 1234
remote_as: "65000.100"
password: "oBztv71m2uhR7hh58/OCNA=="
description: External IPv4 BGP peer
send_community: standard extended
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ tenant_c:
evpn_l2_multi_domain: false
bgp_peer_groups:
- name: Tenant_C_BGP_PEER_GROUP
remote_as: 666
remote_as: "666"
description: "Tenant C peer group"
send_community: all
next_hop_self: true
Expand All @@ -19,7 +19,7 @@ tenant_c:
route_map_in: TEST_IN
local_as: 777
- name: Tenant_C_BGP_PEER_GROUP2
remote_as: 667
remote_as: "667"
description: "Tenant C peer group2"
update_source: lo0
vrfs:
Expand Down Expand Up @@ -48,7 +48,7 @@ tenant_c:
ip_address_virtual: 10.3.50.1/24
bgp_peer_groups:
- name: Tenant_C_WAN_Zone_BGP_PEER_GROUP
remote_as: 666
remote_as: "666"
description: "Tenant C VRF WAN Zone peer group"
send_community: all
next_hop_self: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ tenants:
route_map_out: RM-123-1-1-10-OUT
local_as: 123
- ip_address: 123.1.1.11
remote_as: 1234
remote_as: "1234"
password: "oBztv71m2uhR7hh58/OCNA=="
description: External IPv4 BGP peer
send_community: standard extended
Expand All @@ -191,12 +191,12 @@ tenants:
route_map_out: RM-123-1-1-11-OUT
local_as: 123
- ip_address: fd5a:fe45:8831:06c5::a
remote_as: 12345
remote_as: "12345"
send_community: all
nodes: [DC1-BL1A, DC1-BL1B]
set_ipv6_next_hop: fd5a:fe45:8831:06c5::1
- ip_address: fd5a:fe45:8831:06c5::b
remote_as: 12345
remote_as: "12345"
nodes: [DC1-BL1A, DC1-BL1B]
svis:
- id: 150
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ tenants:
nodes: [DC1-BL1A, DC1-BL1B]
bgp_peers:
- ip_address: 123.1.1.10
remote_as: 1234
remote_as: "1234"
description: External IPv4 BGP peer
send_community: standard extended
maximum_routes: 0
Expand All @@ -114,12 +114,12 @@ tenants:
set_ipv4_next_hop: 123.1.1.1
local_as: 123
- ip_address: fd5a:fe45:8831:06c5::a
remote_as: 12345
remote_as: "12345"
send_community:
nodes: [DC1-BL1A, DC1-BL1B]
set_ipv6_next_hop: fd5a:fe45:8831:06c5::1
- ip_address: fd5a:fe45:8831:06c5::b
remote_as: 12345
remote_as: "12345"
nodes: [DC1-BL1A, DC1-BL1B]
svis:
- id: 150
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
| Variable | Type | Required | Default | Value Restrictions | Description |
| -------- | ---- | -------- | ------- | ------------------ | ----------- |
| [<samp>router_bgp</samp>](## "router_bgp") | Dictionary | | | | |
| [<samp>&nbsp;&nbsp;as</samp>](## "router_bgp.as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;as</samp>](## "router_bgp.as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;router_id</samp>](## "router_bgp.router_id") | String | | | | In IP address format A.B.C.D |
| [<samp>&nbsp;&nbsp;distance</samp>](## "router_bgp.distance") | Dictionary | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;external_routes</samp>](## "router_bgp.distance.external_routes") | Integer | Required | | Min: 1<br>Max: 255 | |
Expand Down Expand Up @@ -45,12 +45,12 @@
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_id_include_router_id</samp>](## "router_bgp.listen_ranges.[].peer_id_include_router_id") | Boolean | | | | Include router ID as part of peer filter |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_group</samp>](## "router_bgp.listen_ranges.[].peer_group") | String | | | | Peer group name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_filter</samp>](## "router_bgp.listen_ranges.[].peer_filter") | String | | | | Peer-filter name<br>note: `peer_filter` or `remote_as` is required but mutually exclusive.<br>If both are defined, `peer_filter` takes precedence<br> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.listen_ranges.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.listen_ranges.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;peer_groups</samp>](## "router_bgp.peer_groups") | List, items: Dictionary | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;- name</samp>](## "router_bgp.peer_groups.[].name") | String | Required, Unique | | | Peer-group name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;type</samp>](## "router_bgp.peer_groups.[].type") | String | | | | Key only used for documentation or validation purposes |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.peer_groups.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.peer_groups.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.peer_groups.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.peer_groups.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;description</samp>](## "router_bgp.peer_groups.[].description") | String | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;shutdown</samp>](## "router_bgp.peer_groups.[].shutdown") | Boolean | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;as_path</samp>](## "router_bgp.peer_groups.[].as_path") | Dictionary | | | | BGP AS-PATH options |
Expand Down Expand Up @@ -98,8 +98,8 @@
| [<samp>&nbsp;&nbsp;neighbors</samp>](## "router_bgp.neighbors") | List, items: Dictionary | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;- ip_address</samp>](## "router_bgp.neighbors.[].ip_address") | String | Required, Unique | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_group</samp>](## "router_bgp.neighbors.[].peer_group") | String | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.neighbors.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.neighbors.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.neighbors.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.neighbors.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;as_path</samp>](## "router_bgp.neighbors.[].as_path") | Dictionary | | | | BGP AS-PATH options |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as_replace_out</samp>](## "router_bgp.neighbors.[].as_path.remote_as_replace_out") | Boolean | | | | Replace AS number with local AS number |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;prepend_own_disabled</samp>](## "router_bgp.neighbors.[].as_path.prepend_own_disabled") | Boolean | | | | Disable prepending own AS number to AS path |
Expand Down Expand Up @@ -515,11 +515,11 @@
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_id_include_router_id</samp>](## "router_bgp.vrfs.[].listen_ranges.[].peer_id_include_router_id") | Boolean | | | | Include router ID as part of peer filter |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_group</samp>](## "router_bgp.vrfs.[].listen_ranges.[].peer_group") | String | | | | Peer-group name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_filter</samp>](## "router_bgp.vrfs.[].listen_ranges.[].peer_filter") | String | | | | Peer-filter name<br>note: `peer_filter`` or `remote_as` is required but mutually exclusive.<br>If both are defined, peer_filter takes precedence<br> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].listen_ranges.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].listen_ranges.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;neighbors</samp>](## "router_bgp.vrfs.[].neighbors") | List, items: Dictionary | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;- ip_address</samp>](## "router_bgp.vrfs.[].neighbors.[].ip_address") | String | Required, Unique | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_group</samp>](## "router_bgp.vrfs.[].neighbors.[].peer_group") | String | | | | Peer-group name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].neighbors.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].neighbors.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;password</samp>](## "router_bgp.vrfs.[].neighbors.[].password") | String | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;passive</samp>](## "router_bgp.vrfs.[].neighbors.[].passive") | Boolean | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remove_private_as</samp>](## "router_bgp.vrfs.[].neighbors.[].remove_private_as") | Dictionary | | | | Remove private AS numbers in outbound AS path |
Expand All @@ -530,7 +530,7 @@
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;enabled</samp>](## "router_bgp.vrfs.[].neighbors.[].remove_private_as_ingress.enabled") | Boolean | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;replace_as</samp>](## "router_bgp.vrfs.[].neighbors.[].remove_private_as_ingress.replace_as") | Boolean | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;weight</samp>](## "router_bgp.vrfs.[].neighbors.[].weight") | Integer | | | Min: 0<br>Max: 65535 | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.vrfs.[].neighbors.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local_as</samp>](## "router_bgp.vrfs.[].neighbors.[].local_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;as_path</samp>](## "router_bgp.vrfs.[].neighbors.[].as_path") | Dictionary | | | | BGP AS-PATH options |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as_replace_out</samp>](## "router_bgp.vrfs.[].neighbors.[].as_path.remote_as_replace_out") | Boolean | | | | Replace AS number with local AS number |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;prepend_own_disabled</samp>](## "router_bgp.vrfs.[].neighbors.[].as_path.prepend_own_disabled") | Boolean | | | | Disable prepending own AS number to AS path |
Expand Down Expand Up @@ -562,7 +562,7 @@
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;prefix_list_out</samp>](## "router_bgp.vrfs.[].neighbors.[].prefix_list_out") | String | | | | Outbound prefix-list name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;neighbor_interfaces</samp>](## "router_bgp.vrfs.[].neighbor_interfaces") | List, items: Dictionary | | | | |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;- name</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].name") | String | Required, Unique | | | Interface name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation <1-65535>.<0-65535> |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;remote_as</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].remote_as") | String | | | | BGP AS <1-4294967295> or AS number in asdot notation "<1-65535>.<0-65535>" |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_group</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].peer_group") | String | | | | Peer-group name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;peer_filter</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].peer_filter") | String | | | | Peer-filter name |
| [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;description</samp>](## "router_bgp.vrfs.[].neighbor_interfaces.[].description") | String | | | | |
Expand Down
Loading

0 comments on commit 86cac32

Please sign in to comment.