Refactor: Correct names - need negative tests

aristanetworks · Dec 20, 2023 · 8964ce0 · 8964ce0
1 parent 4a2356e
commit 8964ce0
Show file tree

Hide file tree

Showing 18 changed files with 332 additions and 228 deletions.
diff --git a/..._collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-edge.cfg b/..._collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-edge.cfg
@@ -26,30 +26,30 @@ router path-selection
          name autovpn-rr2
          ipv4 address 10.8.8.8
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 2
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group INET priority 1
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       42 application-profile it
-         load-balance it_it_lb
+         load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   policy voice
+   policy PROD-AVT-POLICY
       default-match
-         load-balance voice_default_lb
+         load-balance PROD-AVT-POLICY_default_lb
       42 application-profile voice
-         load-balance voice_voice_lb
+         load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      path-selection-policy default-policy
+      path-selection-policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      path-selection-policy prod-policy
+      path-selection-policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !

diff --git a/...e_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-rr1.cfg b/...e_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-rr1.cfg
@@ -16,30 +16,30 @@ router path-selection
       !
       local interface Ethernet1
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 2
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group INET priority 1
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       42 application-profile it
-         load-balance it_it_lb
+         load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   policy voice
+   policy PROD-AVT-POLICY
       default-match
-         load-balance voice_default_lb
+         load-balance PROD-AVT-POLICY_default_lb
       42 application-profile voice
-         load-balance voice_voice_lb
+         load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      path-selection-policy default-policy
+      path-selection-policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      path-selection-policy prod-policy
+      path-selection-policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !

diff --git a/...e_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-rr2.cfg b/...e_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-rr2.cfg
@@ -16,30 +16,30 @@ router path-selection
       !
       local interface Ethernet1
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 2
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group INET priority 1
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       42 application-profile it
-         load-balance it_it_lb
+         load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   policy voice
+   policy PROD-AVT-POLICY
       default-match
-         load-balance voice_default_lb
+         load-balance PROD-AVT-POLICY_default_lb
       42 application-profile voice
-         load-balance voice_voice_lb
+         load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      path-selection-policy default-policy
+      path-selection-policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      path-selection-policy prod-policy
+      path-selection-policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !

diff --git a/...ctions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge.cfg b/...ctions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge.cfg
@@ -37,15 +37,19 @@ router path-selection
       !
       peer dynamic
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_default_lb
+      path-group INET priority 1
+      path-group MPLS priority 2
+   !
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 1
       path-group MPLS priority 1
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
       path-group MPLS priority 2
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group MPLS priority 1
       path-group INET priority 2
 !
@@ -55,33 +59,39 @@ router adaptive-virtual-topology
    zone DEFAULT-ZONE id 1
    site Site511 id 511
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       !
       match application-profile it
-         avt profile it_it
+         avt profile DEFAULT-AVT-POLICY_it
+      !
+      match application-profile default
+         avt profile DEFAULT-AVT-POLICY_default
    !
-   policy voice
+   policy PROD-AVT-POLICY
       !
       match application-profile voice
-         avt profile voice_voice
+         avt profile PROD-AVT-POLICY_voice
       !
       match application-profile default
-         avt profile voice_default
+         avt profile PROD-AVT-POLICY_default
+   !
+   profile DEFAULT-AVT-POLICY_default
+      path-selection load-balance DEFAULT-AVT-POLICY_default_lb
    !
-   profile it_it
-      path-selection load-balance it_it_lb
+   profile DEFAULT-AVT-POLICY_it
+      path-selection load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   profile voice_default
-      path-selection load-balance voice_default_lb
+   profile PROD-AVT-POLICY_default
+      path-selection load-balance PROD-AVT-POLICY_default_lb
    !
-   profile voice_voice
-      path-selection load-balance voice_voice_lb
+   profile PROD-AVT-POLICY_voice
+      path-selection load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      avt policy default-policy
+      avt policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      avt policy prod-policy
+      avt policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !

diff --git a/.../arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-pathfinder.cfg b/.../arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-pathfinder.cfg
@@ -29,48 +29,58 @@ router path-selection
       !
       local interface Ethernet2
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_default_lb
+      path-group INET priority 1
+      path-group MPLS priority 2
+   !
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 1
       path-group MPLS priority 1
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
       path-group MPLS priority 2
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group MPLS priority 1
       path-group INET priority 2
 !
 router adaptive-virtual-topology
    topology role pathfinder
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       !
       match application-profile it
-         avt profile it_it
+         avt profile DEFAULT-AVT-POLICY_it
+      !
+      match application-profile default
+         avt profile DEFAULT-AVT-POLICY_default
    !
-   policy voice
+   policy PROD-AVT-POLICY
       !
       match application-profile voice
-         avt profile voice_voice
+         avt profile PROD-AVT-POLICY_voice
       !
       match application-profile default
-         avt profile voice_default
+         avt profile PROD-AVT-POLICY_default
+   !
+   profile DEFAULT-AVT-POLICY_default
+      path-selection load-balance DEFAULT-AVT-POLICY_default_lb
    !
-   profile it_it
-      path-selection load-balance it_it_lb
+   profile DEFAULT-AVT-POLICY_it
+      path-selection load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   profile voice_default
-      path-selection load-balance voice_default_lb
+   profile PROD-AVT-POLICY_default
+      path-selection load-balance PROD-AVT-POLICY_default_lb
    !
-   profile voice_voice
-      path-selection load-balance voice_voice_lb
+   profile PROD-AVT-POLICY_voice
+      path-selection load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      avt policy default-policy
+      avt policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      avt policy prod-policy
+      avt policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !

diff --git a/...arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-pathfinder1.cfg b/...arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-pathfinder1.cfg
@@ -25,48 +25,58 @@ router path-selection
       !
       local interface Ethernet1
    !
-   load-balance policy it_it_lb
+   load-balance policy DEFAULT-AVT-POLICY_default_lb
+      path-group INET priority 1
+      path-group MPLS priority 2
+   !
+   load-balance policy DEFAULT-AVT-POLICY_it_lb
       path-group INET priority 1
       path-group MPLS priority 1
    !
-   load-balance policy voice_default_lb
+   load-balance policy PROD-AVT-POLICY_default_lb
       path-group INET priority 1
       path-group MPLS priority 2
    !
-   load-balance policy voice_voice_lb
+   load-balance policy PROD-AVT-POLICY_voice_lb
       path-group MPLS priority 1
       path-group INET priority 2
 !
 router adaptive-virtual-topology
    topology role pathfinder
    !
-   policy it
+   policy DEFAULT-AVT-POLICY
       !
       match application-profile it
-         avt profile it_it
+         avt profile DEFAULT-AVT-POLICY_it
+      !
+      match application-profile default
+         avt profile DEFAULT-AVT-POLICY_default
    !
-   policy voice
+   policy PROD-AVT-POLICY
       !
       match application-profile voice
-         avt profile voice_voice
+         avt profile PROD-AVT-POLICY_voice
       !
       match application-profile default
-         avt profile voice_default
+         avt profile PROD-AVT-POLICY_default
+   !
+   profile DEFAULT-AVT-POLICY_default
+      path-selection load-balance DEFAULT-AVT-POLICY_default_lb
    !
-   profile it_it
-      path-selection load-balance it_it_lb
+   profile DEFAULT-AVT-POLICY_it
+      path-selection load-balance DEFAULT-AVT-POLICY_it_lb
    !
-   profile voice_default
-      path-selection load-balance voice_default_lb
+   profile PROD-AVT-POLICY_default
+      path-selection load-balance PROD-AVT-POLICY_default_lb
    !
-   profile voice_voice
-      path-selection load-balance voice_voice_lb
+   profile PROD-AVT-POLICY_voice
+      path-selection load-balance PROD-AVT-POLICY_voice_lb
    !
    vrf default
-      avt policy default-policy
+      avt policy DEFAULT-AVT-POLICY
    !
    vrf PROD
-      avt policy prod-policy
+      avt policy PROD-AVT-POLICY
 !
 spanning-tree mode none
 !