Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Generate CVP Tags #2859

Closed
wants to merge 74 commits into from

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented May 18, 2023

Change Summary

This change adds a new feature: to configure Tags on CloudVision Portal and associate them with Devices and Interfaces.
This will allow for:

  • Correct and amendable generation of the Topology in CVP
  • Make Filtering in Dashboards easier
  • Allow for the specification of custom CVP Tags within the data model.

Related Issue(s)

No issues were raised for this new feature.

Component(s) name

arista.avd.eos_designs
arista.avd.cloudvision

Proposed changes

  • Add cloudvision_tags data structure to the generated eos_designs structured configs
  • Add new arista.avd.cloudvision role to deploy these tags to cloudvision.

How to test

  • Run make webdoc-up to host a local copy of the documentation that can be read on a browser.

  • Run the molecule test -s cloudvision_tags scenario. This will generate the structured config with cv_tags.

To run tests on a cloudvision instance

  • Create a lab with 1 cloudvision and the same devices as defined in cloudvision_tags scenario
  • Ensure devices are onboarded to cloudvision.
  • Set the follow environment variables:
    • CVP_ADDRESS
    • CVP_USERNAME
    • CVP_PASSWORD
  • Run the molecule test -s cloudvision_tags scenario. This will generate the structured config with cv_tags and apply the tags to cloudvision.

Checklist

User Checklist

  • Provide feedback on documentation of new feature.
  • Provide feedback on naming of new role and data model.
  • Test on existing projects and topologies.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label May 18, 2023
@chetryan chetryan changed the title Getting started Feature: Generate CVP Tags May 18, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label May 18, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: code quality CI and development toolset and removed state: conflict PR with conflict labels May 29, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@chetryan chetryan changed the title Feature: Generate CVP Tags Feat(cvp_tags): Generate CVP Tags May 29, 2023
@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label May 29, 2023
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label May 30, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 2, 2023
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 13, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann marked this pull request as draft October 24, 2023 20:17
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 30, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@chetryan chetryan marked this pull request as ready for review October 30, 2023 11:27
@carlbuchmann carlbuchmann marked this pull request as draft October 31, 2023 18:23
@carlbuchmann
Copy link
Member

carlbuchmann commented Oct 31, 2023

Requires the following CVP PR to be merged and new ansible-cvp released: aristanetworks/ansible-cvp#679

@chetryan
Copy link
Contributor Author

Requires the following CVP PR to be merged and new ansible-cvp released: aristanetworks/ansible-cvp#679

That CVP PR has now been merged. Is it time to revisit this PR?

@github-actions github-actions bot added the state: conflict PR with conflict label Dec 15, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista
Copy link
Contributor

Closing this, but keeping the branch, so we can revive as needed later. I will branch from this to implement the subset generating the tags. The tags will then be pushed as part of the new CV integration in #3466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: conflict PR with conflict state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants