-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support STUN #3147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
label
Sep 18, 2023
burnyd
changed the title
Add STUN to eos_cli_gen
Feat(eos_cli_config_gen): Support STUN
Sep 18, 2023
gmuloc
reviewed
Sep 19, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the arista.avd.defined
filters in templates for you. You would now need to add some test under the eos_cli_config_gen
molecule scenario
gmuloc
reviewed
Sep 19, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Sep 19, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Sep 19, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.yml
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Sep 19, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
…tes/documentation/stun.j2 Co-authored-by: Guillaume Mulocher <[email protected]>
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Sep 19, 2023
gmuloc
requested changes
Sep 20, 2023
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/stun.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/stun.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/stun.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/stun.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/stun.yml
Show resolved
Hide resolved
gmuloc
reviewed
Sep 20, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
…entory/host_vars/stun.yml Co-authored-by: Guillaume Mulocher <[email protected]>
…tes/documentation/stun.j2 Co-authored-by: Guillaume Mulocher <[email protected]>
…tes/eos/stun.j2 Co-authored-by: Guillaume Mulocher <[email protected]>
…t server-profiles
ClausHolbechArista
requested changes
Sep 21, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
…tes/documentation/stun.j2 Co-authored-by: Claus Holbech <[email protected]>
…tes/documentation/stun.j2 Co-authored-by: Claus Holbech <[email protected]>
…tes/documentation/stun.j2 Co-authored-by: Claus Holbech <[email protected]>
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/stun.md
Outdated
Show resolved
Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Show resolved
Hide resolved
servers are sorted alphabetically:
Add ing the server-profile
|
Co-authored-by: Claus Holbech <[email protected]>
gmuloc
reviewed
Sep 25, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.yml
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Outdated
Show resolved
Hide resolved
JulioPDX
reviewed
Sep 27, 2023
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/stun.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Sep 29, 2023
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/stun.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/stun.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/stun.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/stun.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/stun.j2
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add new CLI for STUN for eos devices.
It is possible and likely that many of the edge devices will be behind NAT devices. In order for a full mesh of connectivity to be created we need a method of determining the public IP / mapped port of each device. STUN serves this purpose. Each edge will initiate a stun request to the configured STUN server. The STUN server will then record the IP / Port mappings and import that information into BGP 1/79 to be shared with other devices in the network.
Component(s) name
arista.avd.eos_cli_gen
Proposed changes
Add stun for both client and server to eos cli gen
Needed to separate both client and device since there are different possible cli knobs under each. It would render like the following..
Repository Checklist