Feat(eos_cli_config_gen): Support of a global tacacs timeout

[mmaaloul]

Change Summary

Support of tacacs glocal timer setting

Related Issue(s)

Fixes #3126

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

1/ Changed schema fragment "tacacs_servers.schema.yml"
2/ Ran the pre-commit playbook
3/ Changed template eos/tacacs-servers.j2 accordingly

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[gmuloc]

Thanks for this PR - please add some molecule test to cover the newly added knobs.

Some how-to guide for a change to eos_cli_config_gen

eos_cli_config_gen

This part of the change is aimed at adding some new knobs. The following tasks are required:

• Adding the knob to the appropriate schema fragments file in the roles/eos_cli_config_gen/schema/schema_fragments directory (or create a new file if adding a top-level feature)
• Editing the Jinja2 templates in roles/eos_cli_config_gen/templates/eos and roles/eos_cli_config_gen/templates/documentation (or adding new template if adding a top-level feature, in that case, you should also modify the roles/eos_cli_config_gen/templates/eos-device-documentation.j2 and ``roles/eos_cli_config_gen/templates/eos-intended-config.j2 to add these new templates, trying to respect the order in the EOS CLI)
  • NOTE: This one is partially done in your PR as you have modified only the tacacs-servers.j2 template for config but you have not added anything to the documentation templates (it may or may not be necessary)
• Run pre-commit run shemas --all to re-generate the eos_cli_config_gen schema with your modifications (you need to do this every time you change the schema, even if this is just a description changed). This is also used to add the new options to our documentation.
• Add some molecule test in the molecule/eos_cli_config_gen scenario exercising your new knob configuration
  • NOTE: In your case you would need to add to both molecule/eos_cli_config_gen/inventory/host_vars/aaa.yml.
• Run the molecule test locally to generate the new expected configuration and documentation for these two hosts (we recommend running the full scenario using from ansible_collections/arista/avd/molecule folder the command make converge MOLECULE=eos_cli_config_gen
• Run all pre-commit checks pre-commit run --all to make sure that all files you have added are correct and won't be rejected by CI (this command will take ~1min)
• Review that everything added looks correct and push to Github!

Don't hesitate to reach out for any question!

[gmuloc]

If the min and max values are constant across platforms, please add them in the schema as well as a description indicating that this is in "seconds"

leaf1(config)#tacacs-server timeout ?
  <1-1000>  Number of seconds

[mmaaloul]

If I'll put a max/min for global timeout, I shall make the same for the timeout per host. Can I make it as part of the same PR?

[gmuloc]

it can be inserted in this PR yes, but first please check if this is the same on all platforms, otherwise it is probably best to not enforce these.

[gmuloc]

LGTM - Thanks @mmaaloul !